Hacktoberfest 2026：維護者為十月標記出來的 issue，仍然開放、適合新手。 瀏覽 Hacktoberfest issue

Record missing audit events for 13 authorization lifecycle transitions

未關閉
  • 哪裡不對？
#876 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

維護者通常 1 天內回覆

還沒有人認領這個 Issue。

評估

難度
4/5
預估耗時
3-5 天
新手友好度
43/100
Issue 類型
功能
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
typescript
領域
backend-api-design, databases, security

研究方向

Start with server/src/plugins/route-groups/connections.ts, the plugin store writes, and the historical ledger server/tests/pending-authorization-audit-ledger.test.ts at the linked commit; then inspect current behavior tests for each transition. Add persisted audit assertions for the 13 listed gaps, checking actor, attempt correlation, and safe payload while avoiding secret identifiers and duplicate ending events. Done means every transition has a behavior test that verifies its persisted audit event.

由索引模型根據 Issue 內容生成。

描述

PR #872 removes a source-scanning audit ledger that recorded known gaps but did not prove events fired. This issue preserves its 13 debt entries, as requested in review. These are existing gaps, not new regressions from the test cleanup.

Source ledger: pending-authorization-audit-ledger.test.ts at c19d0653. Most transitions are in server/src/plugins/route-groups/connections.ts; store writes are in server/src/plugins/plugin-store.

Dusty confirmed all 13 gaps are still current. The three items marked Priority below should be addressed first: consent can remain live at the vendor with only a console line as the record.

Missing lifecycle audit coverage
  • Claim (claimAuthorizationAttempt, B5e): record who started which consent attempt.
  • Expiry overwrite/re-claim (same call, B5e): record the previous attempt's ending before ON CONFLICT replaces it.
  • Discard after vendor mint refusal (arcade-refused-attempt-not-cleared, B5e): record the refusal/ending, not only cleanup-failure logging.
  • Priority — Discard after successful mint cannot be recorded (arcade-mint-not-recorded, B5e): record that a consent flow may remain live at the vendor.
  • Mint recorded (recordAuthorizationMint, authId: minted.authorizationId, B5e): audit the attempt being bound to a vendor authorization without exposing its secret identifiers.
  • Vendor reports failed consent (failAuthorizationAttempt, settled.status === "failed", B5e): record the terminal verdict.
  • Completed consent has the wrong identity (failAuthorizationAttempt, settled.userId !== attempt.vendorUserId, B5e): record the attribution refusal.
  • Context changed and vendor withdrew retired grant (markAuthorizationWithdrawn, B5e): audit the attempt's verdict; account-disconnection rows alone do not describe it.
  • Priority — Person no longer permitted to act; grant not withdrawn (markAuthorizationUnreconciled, arcade-completion-not-permitted, B5e): record the closed attempt and potentially live vendor consent.
  • Priority — Context changed and withdrawal unconfirmed (markAuthorizationUnreconciled, B5e): record the unresolved grant rather than only a console line.
  • App/server removal cascade (pending_authorizations_server_id_mcp_servers_id_fk, B5e): identify affected in-flight attempts; configuration-change rows currently describe released grants only.
  • Actor removal cascade (pending_authorizations_actor_id_users_id_fk, B5e): identify attempts that die with the actor, including potentially live vendor consent.
  • Cancel loses race to completion (That authorization finished before it could be cancelled, B2c): audit the refused cancellation (409) even though no pending row is deleted.
Acceptance

Exercise each transition through behavior tests and assert the persisted audit event, actor, attempt correlation, and safe payload. Do not log bearer consent URLs or live authorization IDs. Keep the existing successful completion and cancellation events; avoid duplicate attempt-ending events when a cancelled attempt is encountered by a late mint/completion. The original ledger waived those two late-return branches because cancellation had already been audited.

Re-check each gap against current code when implementing; the list preserves the historical findings rather than claiming a new runtime reproduction of all 13.

主要語言
TypeScript
星號
7.1k
分支
962
平均合併
1 天 7 小時
30 天內合併 PR
143

環境準備

  • 提供 Dockerfile 或 Docker Compose 檔案
  • 有 Pull Request 範本
  • 沒有貢獻指南

從這裡開始

  1. 先讀完整個 Issue，再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫，在一個分支上完成修改。
  4. 送出 Pull Request，並在描述裡引用這個 Issue 編號。

CopilotKit/OpenBot 的其他 Issue

查看 CopilotKit/OpenBot 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。