Hacktoberfest 2026 : les issues que les mainteneurs ont marquées pour octobre, ouvertes et accessibles aux débutants. Parcourir les issues Hacktoberfest

Record missing audit events for 13 authorization lifecycle transitions

Ouverte
  • Quelque chose ne va pas ?
#876 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
43/100
Type d'issue
Fonctionnalité
Clarté
Clairement spécifiée
Activité
Active
Stack technique
typescript
Domaine
backend-api-design, databases, security

Piste de recherche

Start with server/src/plugins/route-groups/connections.ts, the plugin store writes, and the historical ledger server/tests/pending-authorization-audit-ledger.test.ts at the linked commit; then inspect current behavior tests for each transition. Add persisted audit assertions for the 13 listed gaps, checking actor, attempt correlation, and safe payload while avoiding secret identifiers and duplicate ending events. Done means every transition has a behavior test that verifies its persisted audit event.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

PR #872 removes a source-scanning audit ledger that recorded known gaps but did not prove events fired. This issue preserves its 13 debt entries, as requested in review. These are existing gaps, not new regressions from the test cleanup.

Source ledger: pending-authorization-audit-ledger.test.ts at c19d0653. Most transitions are in server/src/plugins/route-groups/connections.ts; store writes are in server/src/plugins/plugin-store.

Dusty confirmed all 13 gaps are still current. The three items marked Priority below should be addressed first: consent can remain live at the vendor with only a console line as the record.

Missing lifecycle audit coverage
  • Claim (claimAuthorizationAttempt, B5e): record who started which consent attempt.
  • Expiry overwrite/re-claim (same call, B5e): record the previous attempt's ending before ON CONFLICT replaces it.
  • Discard after vendor mint refusal (arcade-refused-attempt-not-cleared, B5e): record the refusal/ending, not only cleanup-failure logging.
  • Priority — Discard after successful mint cannot be recorded (arcade-mint-not-recorded, B5e): record that a consent flow may remain live at the vendor.
  • Mint recorded (recordAuthorizationMint, authId: minted.authorizationId, B5e): audit the attempt being bound to a vendor authorization without exposing its secret identifiers.
  • Vendor reports failed consent (failAuthorizationAttempt, settled.status === "failed", B5e): record the terminal verdict.
  • Completed consent has the wrong identity (failAuthorizationAttempt, settled.userId !== attempt.vendorUserId, B5e): record the attribution refusal.
  • Context changed and vendor withdrew retired grant (markAuthorizationWithdrawn, B5e): audit the attempt's verdict; account-disconnection rows alone do not describe it.
  • Priority — Person no longer permitted to act; grant not withdrawn (markAuthorizationUnreconciled, arcade-completion-not-permitted, B5e): record the closed attempt and potentially live vendor consent.
  • Priority — Context changed and withdrawal unconfirmed (markAuthorizationUnreconciled, B5e): record the unresolved grant rather than only a console line.
  • App/server removal cascade (pending_authorizations_server_id_mcp_servers_id_fk, B5e): identify affected in-flight attempts; configuration-change rows currently describe released grants only.
  • Actor removal cascade (pending_authorizations_actor_id_users_id_fk, B5e): identify attempts that die with the actor, including potentially live vendor consent.
  • Cancel loses race to completion (That authorization finished before it could be cancelled, B2c): audit the refused cancellation (409) even though no pending row is deleted.
Acceptance

Exercise each transition through behavior tests and assert the persisted audit event, actor, attempt correlation, and safe payload. Do not log bearer consent URLs or live authorization IDs. Keep the existing successful completion and cancellation events; avoid duplicate attempt-ending events when a cancelled attempt is encountered by a late mint/completion. The original ledger waived those two late-return branches because cancellation had already been audited.

Re-check each gap against current code when implementing; the list preserves the historical findings rather than claiming a new runtime reproduction of all 13.

Langage dominant
TypeScript
Étoiles
7.1k
Forks
962
Merge moyen
1 j 6 h
PR mergées (30 j)
143

Préparer son environnement

  • Fournit un Dockerfile ou un fichier Docker Compose
  • Propose un modèle de pull request
  • Aucun guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de CopilotKit/OpenBot

Toutes les issues de CopilotKit/OpenBot

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.