--fail-under says 'no demographic columns detected' for a file whose columns were detected but has no rows
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 88/100
Research direction
Start in faircode/cli.py at the --fail-under check for result["overall_score"] is None, then inspect how result["note"] is populated. Update the error to use that note and run the relevant CLI tests, including a header-only CSV case; done means the message explains that no dimension had non-missing values to measure.
Written by the indexing model from the issue text.
Description
Where: faircode/cli.py (the --fail-under check on result["overall_score"] is None).
Current gap: The message blames missing columns, but a header-only file does have detected dimensions (sex, race); what is missing is data. A CI user chasing the message will inspect the header, which is fine.
Repro:
$ python3 -m faircode profile hdr.csv --fail-under 50
error: cannot apply --fail-under: no demographic columns detected
(hdr.csv is sex,race with no rows)
Suggested approach: use result["note"] ("No dimension had any non-missing values to measure.") in the error so it tells the truth for both cases.
- Dominant language
- HTML
- Stars
- 47
- Forks
- 45
- Avg merge
- 2h 40m
- Merged PRs (30d)
- 90
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from yakew7/Fair-Code
-
bug help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
Maintainers usually reply within 1 day
-
enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
All issues in yakew7/Fair-Code
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
posit-dev/with-connect#62 ·
-
[correctness][missing-coverage][sort] Strict uniqueness checks lack numeric-key equivalence coverageOpen
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
localstack/lstk#538 ·
Maintainers usually reply within 1 day