Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

No tests for Holm tie handling or an empty set of tested pairs in the proxy correction

Closed Beginner friendly
  • Is something wrong?
#820 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

A pull request for this has already been merged.

  • #825 by @Tiyatrotist — merged
  • #832 by @Tiyatrotist — closed without merging

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
82/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
javascript, python
Domain
machine-learning, testing

Research direction

Start with tests/test_proxy.py and tests/test_js_parity.py, then inspect adjust_p_values and adjustPValues to understand the existing test setup. Add cases for tied p-values, one tested pair (m=1), and no testable pairs (m=0), including a Node-side parity check. Done when both implementations return matching expected arrays for these edge cases.

Written by the indexing model from the issue text.

Description

enhancement good first issue

Where: tests/test_proxy.py, tests/test_js_parity.py (adjust_p_values / adjustPValues).

Current gap: The #806 tests cover a hand-computed Holm example and a three-dimension frame, but not ties (two identical p-values, where Python's stable sort and the JS comparator must break ties identically), a single tested pair (m=1: adjusted equals raw), or zero testable pairs (all constant columns).

Repro:

$ grep -n "tie\|m == 1\|empty" tests/test_proxy.py
(no matches)

Suggested approach: parameterised cases for ties, m=1 and m=0 in Python, plus a node-side check that the JS function returns the same arrays.

Dominant language
HTML
Stars
47
Forks
45
Avg merge
2h 36m
Merged PRs (30d)
90

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from yakew7/Fair-Code

All issues in yakew7/Fair-Code

Similar issues

More Machine Learning issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.