tests/test_check_contributors.py is a 740-line file for four modules
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 82/100
Research direction
Start with tests/test_check_contributors.py and inspect its test groups and shared fixtures (DOC, PRS, STUB_DOC, and run). Split the tests across the modules named in the issue and move shared documents into tests/contributors_helpers.py. Run the same tests; done means every test file is under 300 lines and the tests still pass.
Written by the indexing model from the issue text.
Description
Where: tests/test_check_contributors.py.
Current gap: After the script was split (#1319) into contributors_entries.py, contributors_write.py, contributors_github.py and check_contributors.py, all of its tests still sit in one 742-line file with the fixtures (DOC, PRS, STUB_DOC, run) shared at the top.
Suggested approach: Split it per module (entries and checks, rewriting and stubs, GitHub wrappers and the command line) with the shared documents in a tests/contributors_helpers.py.
Done when: no test file is over 300 lines and the same tests pass.
- Dominant language
- HTML
- Stars
- 47
- Forks
- 45
- Avg merge
- 2h 49m
- Merged PRs (30d)
- 69
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from yakew7/Fair-Code
-
enhancement tooling
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
community enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
The weekly external-links issue counts the 403 links with no archive copy but does not list themOpenci enhancement tooling
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
Maintainers usually reply within 1 day
-
enhancement reproducibility tooling
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
check_contributors.py --stub does not say when a pull request's commit is authored by someone elseOpencommunity enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
All issues in yakew7/Fair-Code
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
good first issue help wanted
Difficulty 1/5 Under an hour Newbie friendliness 87/100
Maintainers usually reply within 1 day
-
audit-readme-drift
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
jolars/panache#627 · 1 comment ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
swc-project/swc-next-issues#490 ·