check_contributors.py --stub does not say when a pull request's commit is authored by someone else

Open Beginner friendly
#1,326 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Active
Tech stack
python
Domain
tooling

Research direction

Start with scripts/check_contributors.py (run_stub) and scripts/contributors_write.py (stub_entry), then inspect the existing --pending behavior referenced in issue #1316. Add the stub sentence and the commit_exceptions and unlisted_authors lines when a PR has a foreign commit author. Done when a test using saved data covers that output.

Written by the indexing model from the issue text.

Description

community enhancement

Where: scripts/check_contributors.py (run_stub), scripts/contributors_write.py (stub_entry).

Current gap: --pending now reports a commit authored by someone other than the PR author (#1316), but the stub it starts leaves that out, so for PR #1311 the sentence naming PRIYANKA2272004 and the exception-file lines were written by hand.

Suggested approach: When the commit authors of the stubbed person's PRs include someone else, add a sentence to the stub naming them and print the commit_exceptions and unlisted_authors lines to add.

Done when: a stub for a PR with a foreign commit author includes the sentence and the printed lines, covered by a test with saved data.

Dominant language
HTML
Stars
47
Forks
45
Avg merge
2h 49m
Merged PRs (30d)
69

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from yakew7/Fair-Code

All issues in yakew7/Fair-Code

Similar issues

More DevTools issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.