check_generated_files_current.py's git calls have no timeout

Open Beginner friendly
  • Is something wrong?
#1,305 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
85/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
git, python
Domain
tooling

Research direction

Read scripts/check_generated_files_current.py, focusing on _fresh_build_dir and the calls to git worktree add, git ls-files, and worktree removal. Add timeout handling that names the stalled command and exits 1; use a fake runner to test each relevant timeout path. Done when a stalled git call ends the check with the command named and the test covers it.

Written by the indexing model from the issue text.

Description

ci enhancement tooling

Where: scripts/check_generated_files_current.py (_fresh_build_dir).

Current gap: The three builders now have a timeout (#1292), but git worktree add, git ls-files and the worktree removal run without one, so a stuck git (a lock file, a network filesystem) still hangs the check.

Suggested approach: Pass a timeout to those calls, report which git command stalled and exit 1, and test it with a fake runner.

Done when: a stalled git call ends the check with a message naming it, covered by a test.

Dominant language
HTML
Stars
47
Forks
45
Avg merge
2h 47m
Merged PRs (30d)
92

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from yakew7/Fair-Code

All issues in yakew7/Fair-Code

Similar issues

More DevTools issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.