Document and enforce pull request review guidelines
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 76/100
- Issue type
- Documentation
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- java
- Domain
- developer-experience, documentation
Research direction
Start with the repository-root AGENTS.md and identify how its existing contribution guidance is organized. Draft a root REVIEW.md covering the seven review areas listed in the issue, then reference it from AGENTS.md. Done when both files provide a consistent, usable review checklist for the proposed checks.
Written by the indexing model from the issue text.
Description
Write down what a review of a Wicket pull request checks, so human and agent reviewers apply the same checks to every change, and make the checklist part of the workflow.
AGENTS.md describes how to write a change: format, commits, build, API compatibility, Javadoc, comments, security. Nothing describes what to check when reviewing one. The checks this issue should cover:
- License compliance: ASF headers, the licenses of new dependencies under the ASF third-party policy, and
LICENSE,LICENSE-binary,NOTICEandlicenses/for third-party code or assets copied into the tree. - OSGi and JPMS: the bundle manifest and
module-info.javastay consistent with the pom when packages or dependencies change. - Performance: a change to a hot path keeps its complexity and memory footprint, or shows with a benchmark that the cost is worth it. During the dependency cleanup for #1862, a first draft replaced
LinkedMapinMarkupContainerand made single child removal O(n). - Accessibility: markup, components and JavaScript that render UI keep meeting WCAG.
- Documentation: changes users notice update the migration guide, user guide or Javadoc in the same pull request.
- Serialization: changes to the serialized form of components and models, which affect stored pages and session size.
- Tests: new test classes end in
Test, or Surefire never runs them.
Proposal: a REVIEW.md in the repository root with these checks, referenced from AGENTS.md so agents writing a change check it against the same list.
- Dominant language
- Java
- Stars
- 799
- Forks
- 420
- Avg merge
- 18h 37m
- Merged PRs (30d)
- 140
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from apache/wicket
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
COOP and COEP exemptions compare with the context path, so page exemptions never matchPossibly taken @asvanberg claimed this 18 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
apache/wicket#1661 · 1 comment · 1 reaction ·
Maintainers usually reply within 1 day
-
The CSP report-uri is lost in development mode because strict() clears itMay be free again @VelpulaGangavardhan claimed this 23 days ago, and no pull request is open. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
apache/wicket#1660 · 5 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
Similar issues
-
`Time.at(t, in: nil)` returns UTC instead of the local time (or the time zone of `t`), unlike CRubyOpen
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
hermes-queue
Difficulty 1/5 Under an hour Newbie friendliness 72/100
chrisalunlloyd2-sudo/mindpalace#349 ·
Maintainers usually reply within 1 day
-
Retry-After parser accepts invalid delay-seconds valuesPossibly taken @Dhruvraj-Rana claimed this today. OpenBug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
open-telemetry/opentelemetry-java#9018 ·
Maintainers usually reply within 2 days
-
bug priority: medium Review effort [1-5]: 2 status: needs-triage type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
carlos-emr/carlos#5818 ·
Maintainers usually reply within 1 day
-
bug good first issue help wanted tooling
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
appmonster007/kmip-adapter#100 ·