The benchmark-diff concurrency group cancels the smoke run when the label is added
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 83/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- github-actions, yaml
- Domain
- ci-cd
Research direction
Read .github/workflows/benchmark-diff.yml, starting at its concurrency configuration, and check how the opened/synchronize smoke run and labeled full rerun share a group. Include the event action or job name in the group key so each run type cancels only its own kind. Done when a labelled PR has a finished smoke run and a running full rerun.
Written by the indexing model from the issue text.
Description
Where: .github/workflows/benchmark-diff.yml concurrency.
Current gap: Both the smoke job (opened/synchronize) and the full rerun (labeled) share one group with cancel-in-progress: true. On the throwaway PR #1142 the run started by opened was cancelled the moment the label was added, so a PR that changes the workflow and is labelled never completes its smoke run.
Repro:
gh run list --workflow benchmark-diff.yml # opened run: cancelled; labeled run: in progress
Suggested approach: Put the event action (or the job name) in the group key so the two kinds of run cancel only their own kind.
Done when: a labelled PR shows a finished smoke run and a running full rerun.
- Dominant language
- HTML
- Stars
- 47
- Forks
- 45
- Avg merge
- 3h 2m
- Merged PRs (30d)
- 85
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from yakew7/Fair-Code
-
enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
Maintainers usually reply within 1 day
-
enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
All issues in yakew7/Fair-Code
Similar issues
-
ci enhancement good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 87/100
WordPress/phpunit-test-runner#364 ·
Maintainers usually reply within 4 days
-
[BUG] deploy.restart_policy without condition drops the restart policyPossibly taken @akshat-lakhera claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
docker/compose#14383 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
使用脚本 DD 腾讯云 报错Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100