Include the Whale workspace manifest in FreeBSD cache setup identity
Maintainers usually reply within 1 day
A pull request for this has already been merged.
- #1046 by @amandeavor — merged
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 88/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Domain
- build-system, ci-cd
Research direction
Start at tools/ci/freebsd_cache.py:27, where the dependency-setup manifest inventory is defined. Add whale/Cargo.toml to that inventory while preserving the source-only cache reuse policy and excluding private or untracked files. Verify the result by calling identity() before and after changing only whale/Cargo.toml, then confirm that an application-source-only change still follows the documented restore behavior.
Written by the indexing model from the issue text.
Description
Motivation
The cache identity enumerates root, llvm, utils and front manifests but omits whale/Cargo.toml. Modifying only that manifest in an isolated workspace fixture leaves the identity unchanged. Cargo still checks fresh sources; this does not demonstrate reuse of an incorrect compiler.
Starting point: tools/ci/freebsd_cache.py:27.
Validation
Audited canonical Wave 540728c2eb6cc12f5c69c3fb3fdb96e07ba059a4 (0.0.1-alpha-dev), whose tree matches the local checkout. Validation: Executed actual freebsd_cache.identity() before/after an isolated Whale manifest change. Executed compiler probes use the matching checkout-built compiler and std on Linux amd64 (Rust 1.89.0 / LLVM 21.1.8). Source/header or mocked checks are not native execution on another OS.
Scope
Make the dependency-setup manifest inventory reflect workspace membership, while retaining the intentional source-only cache reuse policy.
Completion criteria
- Changing whale/Cargo.toml affects dependency-setup identity.
- Existing included manifests remain covered, without private/untracked files entering the key.
- An ordinary application-source-only change follows the documented restore policy.
This is a bounded, unassigned task with the starting point and focused checks above. Keep unrelated refactoring out of the change.
- Dominant language
- Rust
- Stars
- 56
- Forks
- 21
- Avg merge
- 7h 19m
- Merged PRs (30d)
- 61
Getting set up
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from wavefnd/Wave
-
Validate CI command vectors before indexing Cargo subcommandsPossibly taken @amandeavor claimed this today. Openbug ci good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
Maintainers usually reply within 1 day
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
build good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 67/100
rust-bitcoin/rust-bitcoin#7089 · 1 comment · 1 reaction ·
Maintainers usually reply within 2 days
-
area/tools bug session-analysis
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
[Bug]: Python OpenTelemetrySectionConfig has no file_sinksMay be free again A pull request for this issue was closed without being merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
NVIDIA/NeMo-Relay#1514 ·
Maintainers usually reply within 1 day
-
prompting proposal tool triaged
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
can1357/oh-my-pi#17041 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 84/100
nix-community/fenix#262 ·