Hacktoberfest 2026: những issue maintainer đã đánh dấu cho tháng Mười, đang mở và phù hợp người mới. Xem issue Hacktoberfest

Entitlements outside supportedTypes stay in the binary but their capability is never enabled on the App ID → late install failure

Đang mở
  • Có gì không ổn?
#352 0 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

Chưa có ai nhận issue này.

Đánh giá

Độ khó
4/5
Thời gian dự kiến
3-5 ngày
Mức phù hợp với người mới
45/100
Loại issue
Lỗi
Độ rõ ràng
Khá rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
ios, swift
Lĩnh vực
devtools, mobile

Hướng nghiên cứu

Start in Sources/XKit/Model/Entitlements/EntitlementTypes.swift, where supportedTypes lists the parse registry and NetworkExtensionEntitlement and DataProtectionEntitlement are missing or commented out. Then check DeveloperServicesAddAppOperation.swift around lines 88 and 182 to see how wanted capabilities are derived from parsed entitlements. Done means these entitlements survive parsing, their capabilities are requested for the App ID, and the value type handles the array and bool forms; PR #334 shows the pattern for AssociatedDomainsEntitlement.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

If the project's entitlements file contains an entitlement whose type is not registered in EntitlementContainer.supportedTypes — today that's at least com.apple.developer.networking.networkextension and com.apple.developer.default-data-protection — xtool dev (device install) keeps the entitlement in the signed binary but never enables the matching capability on the App ID it registers. The device then rejects the install late, with an error that doesn't point at the cause. On free teams the entitlement is instead silently dropped and the feature just doesn't work.

Code trace
  • Sources/XKit/Model/Entitlements/EntitlementTypes.swift:15-30 — supportedTypes is the parse registry. NetworkExtensionEntitlement.self is commented out at line 23, AssociatedDomainsEntitlement.self at line 20; DataProtectionEntitlement (defined at line 109) is missing from the list entirely.
  • Entitlements.entitlements() decodes through ProtoCodableKeyValueContainer, which explicitly skips unknown keys (guard T.protoCodableType(for: key.stringValue) != nil else { continue } in xtool-core, ProtoCodableKeyValueContainer.swift:58-59). Unregistered entitlements never come back from entitlements().
  • Capability registration is computed only from parsed entitlements: Sources/XKit/DeveloperServices/App IDs/DeveloperServicesAddAppOperation.swift:88 — wantedCapabilitiesList = try entitlements.entitlements().compactMap(\.anyCapability). So the App ID never gets the network-extension / data-protection capability enabled, and DeveloperServicesFetchProfileOperation returns a profile that doesn't grant those entitlements.
  • Meanwhile the raw dictionary inside Entitlements retains unknown keys by design (the type's doc comment says so), and AutoSigner signs with that full mapping (Sources/XKit/Signer/AutoSigner.swift:85-92), so the binary does embed the entitlement.
  • Result for a paid team: binary entitlements ⊃ profile entitlements → install fails at device verification (the classic "entitlements not granted by the provisioning profile" class of error), long after configure/build succeeded with no warning.
  • Result for a free team: DeveloperServicesAddAppOperation.swift:182 filters to free capabilities and rebuilds Entitlements from the filtered list, silently discarding the entitlement from the binary.

The capability mappings for these entitlements already exist and are complete — Sources/XKit/DeveloperServices/App IDs/Entitlements/DeveloperServicesCapability.swift maps NetworkExtensionEntitlement → .networkExtensions and DataProtectionEntitlement → .dataProtection (with settings) — they're just unreachable because the types aren't registered.

Repro / expectations

A VPN or network-extension app with a paid team:

  1. xtool.yml with entitlementsPath pointing at a plist containing com.apple.developer.networking.networkextension.
  2. xtool dev builds and provisions with no warnings.
  3. The install on the device fails with an entitlement/profile mismatch error.

(I verified the code path statically; I haven't reproduced the device-side rejection on hardware.)

Suggested direction
  • Register the remaining entitlement types so their capabilities get provisioned. One caveat: the real-world value of com.apple.developer.networking.networkextension is often an array of extension kinds (e.g. ["packet-tunnel-provider"]) or a bool, so the current rawValue: Bool modeling would need adjusting.
  • PR #334 does this for AssociatedDomainsEntitlement only.
  • Independently of how many types get registered, a warning when an entitlements file contains keys xtool won't provision would turn this into a configure-time error instead of a late install failure — the set of entitlements Apple supports grows faster than this registry.
Ngôn ngữ chính
Swift
Star
5.5k
Fork
163
Merge trung bình
19 giờ 33 phút
Pull request đã merge (30 ngày)
25

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của xtool-org/xtool

Tất cả issue của xtool-org/xtool

Issue tương tự

Thêm issue về Swift

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.