Entitlements outside supportedTypes stay in the binary but their capability is never enabled on the App ID → late install failure
メンテナーはふだん 1 日以内に返信
まだ誰も着手していません。
評価
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 初心者へのやさしさ
- 45/100
調査の方向性
Start in Sources/XKit/Model/Entitlements/EntitlementTypes.swift, where supportedTypes lists the parse registry and NetworkExtensionEntitlement and DataProtectionEntitlement are missing or commented out. Then check DeveloperServicesAddAppOperation.swift around lines 88 and 182 to see how wanted capabilities are derived from parsed entitlements. Done means these entitlements survive parsing, their capabilities are requested for the App ID, and the value type handles the array and bool forms; PR #334 shows the pattern for AssociatedDomainsEntitlement.
索引モデルが issue の本文から書いたものです。
説明
If the project's entitlements file contains an entitlement whose type is not registered in EntitlementContainer.supportedTypes — today that's at least com.apple.developer.networking.networkextension and com.apple.developer.default-data-protection — xtool dev (device install) keeps the entitlement in the signed binary but never enables the matching capability on the App ID it registers. The device then rejects the install late, with an error that doesn't point at the cause. On free teams the entitlement is instead silently dropped and the feature just doesn't work.
Code trace
Sources/XKit/Model/Entitlements/EntitlementTypes.swift:15-30—supportedTypesis the parse registry.NetworkExtensionEntitlement.selfis commented out at line 23,AssociatedDomainsEntitlement.selfat line 20;DataProtectionEntitlement(defined at line 109) is missing from the list entirely.Entitlements.entitlements()decodes throughProtoCodableKeyValueContainer, which explicitly skips unknown keys (guard T.protoCodableType(for: key.stringValue) != nil else { continue }in xtool-core, ProtoCodableKeyValueContainer.swift:58-59). Unregistered entitlements never come back fromentitlements().- Capability registration is computed only from parsed entitlements:
Sources/XKit/DeveloperServices/App IDs/DeveloperServicesAddAppOperation.swift:88—wantedCapabilitiesList = try entitlements.entitlements().compactMap(\.anyCapability). So the App ID never gets the network-extension / data-protection capability enabled, andDeveloperServicesFetchProfileOperationreturns a profile that doesn't grant those entitlements. - Meanwhile the raw dictionary inside
Entitlementsretains unknown keys by design (the type's doc comment says so), andAutoSignersigns with that full mapping (Sources/XKit/Signer/AutoSigner.swift:85-92), so the binary does embed the entitlement. - Result for a paid team: binary entitlements ⊃ profile entitlements → install fails at device verification (the classic "entitlements not granted by the provisioning profile" class of error), long after configure/build succeeded with no warning.
- Result for a free team:
DeveloperServicesAddAppOperation.swift:182filters to free capabilities and rebuildsEntitlementsfrom the filtered list, silently discarding the entitlement from the binary.
The capability mappings for these entitlements already exist and are complete — Sources/XKit/DeveloperServices/App IDs/Entitlements/DeveloperServicesCapability.swift maps NetworkExtensionEntitlement → .networkExtensions and DataProtectionEntitlement → .dataProtection (with settings) — they're just unreachable because the types aren't registered.
Repro / expectations
A VPN or network-extension app with a paid team:
xtool.ymlwithentitlementsPathpointing at a plist containingcom.apple.developer.networking.networkextension.xtool devbuilds and provisions with no warnings.- The install on the device fails with an entitlement/profile mismatch error.
(I verified the code path statically; I haven't reproduced the device-side rejection on hardware.)
Suggested direction
- Register the remaining entitlement types so their capabilities get provisioned. One caveat: the real-world value of
com.apple.developer.networking.networkextensionis often an array of extension kinds (e.g.["packet-tunnel-provider"]) or a bool, so the currentrawValue: Boolmodeling would need adjusting. - PR #334 does this for
AssociatedDomainsEntitlementonly. - Independently of how many types get registered, a warning when an entitlements file contains keys xtool won't provision would turn this into a configure-time error instead of a late install failure — the set of entitlements Apple supports grows faster than this registry.
- 主要言語
- Swift
- スター
- 5.5k
- フォーク
- 163
- 平均マージ
- 19時間 33分
- マージ済み PR(30日)
- 25
環境構築
- Dockerfile または Docker Compose ファイルあり
- プルリクエストのテンプレートあり
- コントリビューションガイドを読む
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
xtool-org/xtool のほかの issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 63/100
メンテナーはふだん 1 日以内に返信
-
難易度 4/5 3〜5日 初心者へのやさしさ 45/100
メンテナーはふだん 1 日以内に返信
-
Error: exited(127)オープンbug
難易度 3/5 1〜2日 初心者へのやさしさ 45/100
メンテナーはふだん 1 日以内に返信
-
enhancement
難易度 5/5 1週間以上 初心者へのやさしさ 35/100
xtool-org/xtool#365 · コメント 1 件 ·
メンテナーはふだん 1 日以内に返信
-
enhancement
難易度 5/5 1週間以上 初心者へのやさしさ 20/100
xtool-org/xtool#364 · リアクション 9 件 ·
メンテナーはふだん 1 日以内に返信
xtool-org/xtool の issue をすべて見る
似ている issue
-
難易度 2/5 1〜3時間 初心者へのやさしさ 88/100
Lakr233/vphone-cli#745 ·
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 76/100
メンテナーはふだん 1 日以内に返信
-
難易度 2/5 1〜3時間 初心者へのやさしさ 65/100
-
難易度 2/5 1〜3時間 初心者へのやさしさ 83/100
cucumberswift/CucumberSwift#495 ·
メンテナーはふだん 1 日以内に返信
-
enhancement good first issue help wanted
難易度 2/5 1〜3時間 初心者へのやさしさ 82/100
omlahore/RemoveMacAI#91 ·
メンテナーはふだん 1 日以内に返信