Local-dev step stack traces: wrong lines, and function names that depend on step-executor.ts line offsets

Đang mở
#4,352 0 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

Chưa có ai nhận issue này.

Đánh giá

Độ khó
4/5
Thời gian dự kiến
3-5 ngày
Mức phù hợp với người mới
45/100
Loại issue
Lỗi
Độ rõ ràng
Đặc tả rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
node.js, typescript, vite

Hướng nghiên cứu

The issue is in the SWC transform configuration in packages/builders/src/apply-swc-transform.ts where sourceMaps: false. The failing tests are in packages/core/e2e/e2e.test.ts under 'basic step error preserves message and stack trace' and 'cross-file step error preserves message and function names in stack'. Start by enabling source maps inline to see the correct positions and the doubled path issue. Then trace how the source map is passed to the esbuild step bundle and how function names are resolved in the dev SSR runner. 'Done' is when the tests pass regardless of line offsets in packages/core/src/runtime/step-executor.ts.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

The E2E Local Dev Tests step-error assertions (packages/core/e2e/e2e.test.ts, "basic step error preserves message and stack trace" and "cross-file step error preserves message and function names in stack") pass or fail depending on unrelated line offsets in packages/core/src/runtime/step-executor.ts. On current main they pass by coincidence.

Reproduction (sveltekit, pnpm dev, same env as the CI job)
  • main @ 2694663ae: pass. The reported frame is at errorStepFn (workbench/example/workflows/99_e2e.ts:992:11), so the name is right, but the line isn't: errorStepFn throws at line 1424.
  • main + five comment-only lines inserted in step-executor.ts above the step call (// inert ×5 before const createEvent in executeStep): both tests fail. The frame becomes at _a (…/99_e2e.ts:992:11), and the cross-file test reports at _a (…/helpers.ts:21:22). dev.test.ts isn't needed to trigger it, and it happens with both WORKFLOW_VM=node and quickjs.
  • CI hit the same thing on all four astro/sveltekit × node/quickjs local-dev jobs of vercel/workflow#4348, whose first revision added five lines to that function. On CI's retry, the name moved to a different wrong function (hookGetConflictWithPriorStepWorkflow).
What's going on
  1. Positions: packages/builders/src/apply-swc-transform.ts runs the SWC transform with sourceMaps: false, with a TODO to investigate. Step-bundle positions therefore point into the transformed code instead of the original file. That's why every step frame reads 99_e2e.ts:992 whatever the throw site is.
    • As an experiment, sourceMaps: 'inline' makes the position correct (99_e2e.ts:1424:9).
    • It also doubles the path (workbench/example/workflows/example/workflows/99_e2e.ts), so the source paths in the map need fixing too.
  2. Names: with (1) fixed, the name is still _a. The frame name comes from source-map name resolution rather than from V8's function name. For Node's --enable-source-maps, that's the enclosing-function or caller-site entry in the map, plus Vite's SSR module runner for eval'd modules. So an offset in how those positions are looked up makes the name depend on where code lands in step-executor.ts.
Impact

Any PR that shifts lines in step-executor.ts can fail these four required jobs for reasons unrelated to its change. Separately, dev-mode step stacks report wrong lines today.

Suggested fix

Emit and chain the SWC transform's source map into the esbuild step bundle, fixing the sources paths. Then check how function names are resolved for step frames in the dev SSR runner, or have the test assert on the frame position instead of relying on the source-map name.

🤖 Generated with Claude Code

Ngôn ngữ chính
TypeScript
Star
2.5k
Fork
401
Merge trung bình
1 ngày 21 giờ
Pull request đã merge (30 ngày)
201

Chuẩn bị môi trường

  • Không có Dockerfile hay tệp Docker Compose
  • Có mẫu pull request
  • Không có hướng dẫn đóng góp

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của vercel/workflow

Tất cả issue của vercel/workflow

Issue tương tự

Thêm issue về TypeScript

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.