Local-dev step stack traces: wrong lines, and function names that depend on step-executor.ts line offsets
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 45/100
- Tipo de issue
- Error
- Claridad
- Bien especificado
- Estado de actividad
- Activo
- Stack tecnológico
- node.js, typescript, vite
- Área
- developer-experience, testing, tooling
Línea de trabajo
The issue is in the SWC transform configuration in packages/builders/src/apply-swc-transform.ts where sourceMaps: false. The failing tests are in packages/core/e2e/e2e.test.ts under 'basic step error preserves message and stack trace' and 'cross-file step error preserves message and function names in stack'. Start by enabling source maps inline to see the correct positions and the doubled path issue. Then trace how the source map is passed to the esbuild step bundle and how function names are resolved in the dev SSR runner. 'Done' is when the tests pass regardless of line offsets in packages/core/src/runtime/step-executor.ts.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
The E2E Local Dev Tests step-error assertions (packages/core/e2e/e2e.test.ts, "basic step error preserves message and stack trace" and "cross-file step error preserves message and function names in stack") pass or fail depending on unrelated line offsets in packages/core/src/runtime/step-executor.ts. On current main they pass by coincidence.
Reproduction (sveltekit, pnpm dev, same env as the CI job)
main@2694663ae: pass. The reported frame isat errorStepFn (workbench/example/workflows/99_e2e.ts:992:11), so the name is right, but the line isn't:errorStepFnthrows at line 1424.main+ five comment-only lines inserted instep-executor.tsabove the step call (// inert×5 beforeconst createEventinexecuteStep): both tests fail. The frame becomesat _a (…/99_e2e.ts:992:11), and the cross-file test reportsat _a (…/helpers.ts:21:22).dev.test.tsisn't needed to trigger it, and it happens with bothWORKFLOW_VM=nodeandquickjs.- CI hit the same thing on all four astro/sveltekit × node/quickjs local-dev jobs of vercel/workflow#4348, whose first revision added five lines to that function. On CI's retry, the name moved to a different wrong function (
hookGetConflictWithPriorStepWorkflow).
What's going on
- Positions:
packages/builders/src/apply-swc-transform.tsruns the SWC transform withsourceMaps: false, with a TODO to investigate. Step-bundle positions therefore point into the transformed code instead of the original file. That's why every step frame reads99_e2e.ts:992whatever the throw site is.- As an experiment,
sourceMaps: 'inline'makes the position correct (99_e2e.ts:1424:9). - It also doubles the path (
workbench/example/workflows/example/workflows/99_e2e.ts), so the source paths in the map need fixing too.
- As an experiment,
- Names: with (1) fixed, the name is still
_a. The frame name comes from source-map name resolution rather than from V8's function name. For Node's--enable-source-maps, that's the enclosing-function or caller-site entry in the map, plus Vite's SSR module runner for eval'd modules. So an offset in how those positions are looked up makes the name depend on where code lands instep-executor.ts.
Impact
Any PR that shifts lines in step-executor.ts can fail these four required jobs for reasons unrelated to its change. Separately, dev-mode step stacks report wrong lines today.
Suggested fix
Emit and chain the SWC transform's source map into the esbuild step bundle, fixing the sources paths. Then check how function names are resolved for step frames in the dev SSR runner, or have the test assert on the frame position instead of relying on the source-map name.
🤖 Generated with Claude Code
- Lenguaje dominante
- TypeScript
- Estrellas
- 2.5k
- Forks
- 401
- Merge medio
- 1 d 21 h
- PR fusionados (30 d)
- 201
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Sin guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de vercel/workflow
-
getPortLazy re-runs OS port discovery on every call when it finds no portPosiblemente ocupada Un pull request vinculado a esta issue está abierto o ya se fusionó. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
Los mantenedores suelen responder en 1 día
-
node-module-esbuild-plugin: getImportedIdentifier only checks the first named import when locating a violationPosiblemente ocupada @div-cowboy la tomó hace 5 días. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
vercel/workflow#5057 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 74/100
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
Los mantenedores suelen responder en 1 día
-
code-transform.mdx §ID Generation omits the package-shipped `name@version` ID formPosiblemente ocupada @Mohith26 la tomó hace 113 días. Abierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 90/100
Los mantenedores suelen responder en 1 día
Todos los issues de vercel/workflow
Issues similares
-
Dificultad 1/5 1-3 horas Aptitud para principiantes 87/100
Los mantenedores suelen responder en 1 día
-
🛠️ dette technique
Dificultad 2/5 1-3 horas Aptitud para principiantes 61/100
betagouv/mon-entreprise#4752 · 1 comentario ·
Los mantenedores suelen responder en 5 días
-
type: bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 67/100
franciscoBSalgueiro/en-croissant#1111 ·
Los mantenedores suelen responder en 2 días
-
area/providers type/feature version/v2
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
anomalyco/opencode#64845 · 1 comentario ·
Los mantenedores suelen responder en 1 día
-
enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
Los mantenedores suelen responder en 1 día