Improve transaction list and report performance with four targeted query and index changes

Đang mở
#466 0 bình luận 0 reaction 0 người được giao Xem trên GitHub

Chưa có ai nhận issue này.

Đánh giá

Độ khó
4/5
Thời gian dự kiến
3-5 ngày
Mức phù hợp với người mới
35/100
Loại issue
Lỗi
Độ rõ ràng
Khá rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
csharp
Lĩnh vực
database, performance

Hướng nghiên cứu

Start with the list query in TransactionsController.cs, the report query in ReportsController.cs, and the report projection in TransfersReportViewModel.cs; read the shared _TransactionsTable.cshtml before changing its models or partials. Compare generated SQL and behavior for transactions with multiple transfers and metadata, then measure the proposed projections and covering index using the listed TEST ranges. Done means preserving filters and report contents while recording performance results and a reversible index migration plan.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

Larger date ranges make the transaction list and downloadable transactions report slow or unusable on the DEVAR production instance. Reduce database reads, duplicated result rows, and application memory use through four targeted changes, preserving the existing filters, displayed values, and exports.

Read-only investigation on October 21, 2026 found:

  • DEVAR has one team and one source, approximately 275,634 transactions, 1.16 million transfers, and 803,000 transaction metadata records. Its default date range is already seven days.
  • Over the preceding 14 days, the main transaction list query averaged 13.4 seconds across 171 completed executions, peaked at 176 seconds, and recorded two aborted executions around 30 seconds.
  • The downloadable report recorded a 26-second completion and two aborted executions, one at 30 seconds. The completed execution returned 33,267 joined rows and performed approximately 494,450 logical reads.
  • Existing transaction-date and transfer-transaction indexes are present and used by the execution plans. Both queries still perform many lookups into full rows. Query Store shows substantial data-read waits, and Azure metrics show read-I/O utilization reaching 100%.
  • The list loads every matching transaction and its transfers before rendering HTML. The report loads transfers and metadata and renders one table row per transfer. DataTables paginates the resulting HTML in the browser.

Implement and evaluate these four changes:

  1. Split the downloadable report query and disable tracking. Add query-local AsSplitQuery() and AsNoTracking(). The current generated SQL joins both transfers and metadata at the transaction level: four transfers and three metadata entries produce 12 intermediate rows. Fetching the collections separately should remove this multiplication. Keep this scoped to the report rather than changing the DbContext default. Verify behavior if transactions change between the separate reads.

  2. Calculate report totals and transfer counts once from the transfers already loaded. The current projection loads transfers and additionally issues correlated SUM and COUNT subqueries over them. The stored plan shows repeated transfer reads and lookups. After materialization, calculate the credit-only total and transfer count from the loaded collection, preserving decimal precision and existing report semantics.

  3. Project only the fields needed by the list and report. Both paths currently retrieve full transfer entities, including unused legacy accounting fields. Introduce focused read models for the displayed transaction fields and required transfer fields. Preserve the transaction-description/debit-description fallback, credit totals, account strings, metadata formatting, transfer ordering, links, and hidden fields used by search or exports. Check other consumers before changing shared transaction-table models or partials.

  4. Benchmark a covering transfer index alongside the smaller projections. Candidate: Transfers(TransactionId) INCLUDE (Direction, Amount, Description, FinancialSegmentString). The existing IX_Transfers_TransactionId does not contain these displayed fields, so the current plans fetch them through additional table lookups. Confirm the final projected columns and execution plans before choosing the index definition. Measure read benefits, index size, and write overhead; avoid introducing a redundant index without evidence. A source/date composite index is lower priority for DEVAR because its single source adds little selectivity and the date index is already used.

Relevant code:

Validate in TEST with representative DEVAR-scale data:

  • Compare before/after query time, logical reads, returned SQL rows, and application memory for identical 7-, 30-, and 90-day ranges. Record first-observed and repeated timings separately.
  • Confirm identical transaction and transfer counts, credit totals, descriptions, accounts, metadata, and export contents. Include transactions with multiple transfers and metadata entries.
  • Preserve team authorization, tracking-number lookup behavior, merchant filters, and date-range boundaries.
  • Verify generated SQL avoids the transfers/metadata cross product and repeated report aggregate subqueries, and confirm the candidate index helps the final query shape before retaining it.
  • Provide a reversible index migration and rollback plan. Production application or schema changes require separate approval after TEST validation.

These are evidence-backed candidates, not measured improvements yet. Server-side pagination, server-generated exports, and Azure tier upgrades are separate work. The existing unbounded HTML response remains a scaling limit after these optimizations. This issue records the investigation and proposed scope; no implementation or production changes have been made.

Ngôn ngữ chính
C#
Star
4
Fork
2
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Chuẩn bị môi trường

Dự án này không cung cấp dev container, Dockerfile hay hướng dẫn đóng góp, nên bạn cần tự thiết lập môi trường: hãy bắt đầu từ README và xem hướng dẫn đóng góp lần đầu của chúng tôi để biết các bước chung.

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của ucdavis/Sloth

Tất cả issue của ucdavis/Sloth

Issue tương tự

Thêm issue về C#

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.