Improve transaction list and report performance with four targeted query and index changes

Aperta
#466 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
csharp

Direzione di ricerca

Start with the list query in TransactionsController.cs, the report query in ReportsController.cs, and the report projection in TransfersReportViewModel.cs; read the shared _TransactionsTable.cshtml before changing its models or partials. Compare generated SQL and behavior for transactions with multiple transfers and metadata, then measure the proposed projections and covering index using the listed TEST ranges. Done means preserving filters and report contents while recording performance results and a reversible index migration plan.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Larger date ranges make the transaction list and downloadable transactions report slow or unusable on the DEVAR production instance. Reduce database reads, duplicated result rows, and application memory use through four targeted changes, preserving the existing filters, displayed values, and exports.

Read-only investigation on October 21, 2026 found:

  • DEVAR has one team and one source, approximately 275,634 transactions, 1.16 million transfers, and 803,000 transaction metadata records. Its default date range is already seven days.
  • Over the preceding 14 days, the main transaction list query averaged 13.4 seconds across 171 completed executions, peaked at 176 seconds, and recorded two aborted executions around 30 seconds.
  • The downloadable report recorded a 26-second completion and two aborted executions, one at 30 seconds. The completed execution returned 33,267 joined rows and performed approximately 494,450 logical reads.
  • Existing transaction-date and transfer-transaction indexes are present and used by the execution plans. Both queries still perform many lookups into full rows. Query Store shows substantial data-read waits, and Azure metrics show read-I/O utilization reaching 100%.
  • The list loads every matching transaction and its transfers before rendering HTML. The report loads transfers and metadata and renders one table row per transfer. DataTables paginates the resulting HTML in the browser.

Implement and evaluate these four changes:

  1. Split the downloadable report query and disable tracking. Add query-local AsSplitQuery() and AsNoTracking(). The current generated SQL joins both transfers and metadata at the transaction level: four transfers and three metadata entries produce 12 intermediate rows. Fetching the collections separately should remove this multiplication. Keep this scoped to the report rather than changing the DbContext default. Verify behavior if transactions change between the separate reads.

  2. Calculate report totals and transfer counts once from the transfers already loaded. The current projection loads transfers and additionally issues correlated SUM and COUNT subqueries over them. The stored plan shows repeated transfer reads and lookups. After materialization, calculate the credit-only total and transfer count from the loaded collection, preserving decimal precision and existing report semantics.

  3. Project only the fields needed by the list and report. Both paths currently retrieve full transfer entities, including unused legacy accounting fields. Introduce focused read models for the displayed transaction fields and required transfer fields. Preserve the transaction-description/debit-description fallback, credit totals, account strings, metadata formatting, transfer ordering, links, and hidden fields used by search or exports. Check other consumers before changing shared transaction-table models or partials.

  4. Benchmark a covering transfer index alongside the smaller projections. Candidate: Transfers(TransactionId) INCLUDE (Direction, Amount, Description, FinancialSegmentString). The existing IX_Transfers_TransactionId does not contain these displayed fields, so the current plans fetch them through additional table lookups. Confirm the final projected columns and execution plans before choosing the index definition. Measure read benefits, index size, and write overhead; avoid introducing a redundant index without evidence. A source/date composite index is lower priority for DEVAR because its single source adds little selectivity and the date index is already used.

Relevant code:

Validate in TEST with representative DEVAR-scale data:

  • Compare before/after query time, logical reads, returned SQL rows, and application memory for identical 7-, 30-, and 90-day ranges. Record first-observed and repeated timings separately.
  • Confirm identical transaction and transfer counts, credit totals, descriptions, accounts, metadata, and export contents. Include transactions with multiple transfers and metadata entries.
  • Preserve team authorization, tracking-number lookup behavior, merchant filters, and date-range boundaries.
  • Verify generated SQL avoids the transfers/metadata cross product and repeated report aggregate subqueries, and confirm the candidate index helps the final query shape before retaining it.
  • Provide a reversible index migration and rollback plan. Production application or schema changes require separate approval after TEST validation.

These are evidence-backed candidates, not measured improvements yet. Server-side pagination, server-generated exports, and Azure tier upgrades are separate work. The existing unbounded HTML response remains a scaling limit after these optimizations. This issue records the investigation and proposed scope; no implementation or production changes have been made.

Lingua principale
C#
Stelle
4
Fork
2
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di ucdavis/Sloth

Tutte le issue di ucdavis/Sloth

Issue simili

Altre issue su C#

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.