Fantom's tester does not build with Clang 22 or later: the skcms of its pinned Skia (3f8fc145) calls __builtin_ia32_vcvtph2ps256

Đang mở
#59,967 0 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 2 ngày

Chưa có ai nhận issue này.

Đánh giá

Độ khó
3/5
Thời gian dự kiến
1-2 ngày
Mức phù hợp với người mới
66/100
Loại issue
Lỗi
Độ rõ ràng
Đặc tả rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
c, cmake, cpp
Lĩnh vực
build-system, mobile-dev

Hướng nghiên cứu

Start with the Skia revision pinned in private/react-native-fantom/build.gradle.kts and the tester's Skia build configuration in private/react-native-fantom/tester/third-party/skia/CMakeLists.txt. Compare its skcms implementation with the cited upstream fix, then reproduce with Clang 22 or later using the reported yarn workspace build command. Done means the Fantom tester builds and Skia renders as expected.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

Needs: Triage :mag:
Description

Since cea863e (#59482), Fantom's tester builds Skia at the revision private/react-native-fantom/build.gradle.kts pins, 3f8fc145ba678f3bd47af50f8fb51bcde474ef9c. That Skia's third_party/skcms/src/Transform_inl.h L169 calls __builtin_ia32_vcvtph2ps256 in the AVX2 path that skcms.cc compiles for runtime CPU detection. Clang 21 declares that builtin (BuiltinsX86.td L759), and Clang 22 and later do not, so yarn workspace @react-native/fantom build fails with Clang 22 or later.

skcms replaced the call with __builtin_convertvector in 135488419331 (2025-08-15), and current Skia carries that in modules/skcms.

Steps to reproduce
  1. git clone https://github.com/YevheniiKotyrlo/react-native-fantom-reproducer && cd react-native-fantom-reproducer
  2. ./fantom/reproduce.sh skia-clang-23 (needs Docker). It clones react/react-native at main into the image Fantom's CI job builds in, with Clang 23.1.3 in place of the apt Clang. Then it runs yarn workspace @react-native/fantom build with CXXFLAGS=-Wno-error=deprecated-literal-operator, which keeps nlohmann_json's warning (#59667) from stopping the build first. It ends with a SUMMARY: line and exits 1 while the build stops on __builtin_ia32_vcvtph2ps256, 0 once the tester builds, and 2 when it fails another way.

The same on a checkout of main, with Clang 22 or later as CC and CXX:

export CXXFLAGS=-Wno-error=deprecated-literal-operator
yarn workspace @react-native/fantom build

Expected: the tester builds with Clang 22 or later, as it does with the CI's Clang, and Skia renders as it does now.

Seen: the build stops in the pinned Skia's skcms on use of undeclared identifier '__builtin_ia32_vcvtph2ps256' (the log under Stacktrace or Logs). The reproducer's other cases add -DSKCMS_NO_RUNTIME_CPU_DETECTION to the Skia extra_cflags in private/react-native-fantom/tester/third-party/skia/CMakeLists.txt, which leaves out that AVX2 path, and with it the same build succeeds.

React Native Version

main at 1273ca1 (0.90.0-nightly-20261111-1273ca128); 0.88 and 0.89 build no Skia into the tester

Affected Platforms

Build - Linux

Output of npx @react-native-community/cli info

The reproducer runs in Docker on Linux x64, in reactnativecommunity/react-native-android:v22.0. Its first lines:

react-native 1273ca128fa378e231dd351a65fb7d63fe0b6526, committed 2026-11-11T01:34:33+00:00
clang version 23.1.3 (https://github.com/llvm/llvm-project 0d261d1ca552c95a8f007e061c787ac7132fbcbc)
Skia 3f8fc145ba678f3bd47af50f8fb51bcde474ef9c
Stacktrace or Logs
> Task :private:react-native-fantom:buildFantomTester FAILED
* What went wrong:
Execution failed for task ':private:react-native-fantom:buildFantomTester'.
> Process 'command '/opt/android/cmake/3.30.5/bin/cmake'' finished with non-zero exit value 2

../../../third-party/skia/third_party/skcms/src/Transform_inl.h:169:12: error: use of undeclared identifier '__builtin_ia32_vcvtph2ps256'; did you mean '__builtin_ia32_cvtpd2ps256'?
../../../third-party/skia/third_party/skcms/src/Transform_inl.h:169:40: error: cannot initialize a parameter of type '__attribute__((__vector_size__(4 * sizeof(double)))) double' (vector of 4 'double' values) with an rvalue of type 'I16' (vector of 8 'int16_t' values)
SUMMARY: the skcms of the tester's Skia calls __builtin_ia32_vcvtph2ps256, which Clang 23 does not declare
MANDATORY Reproducer

https://github.com/YevheniiKotyrlo/react-native-fantom-reproducer

Screenshots and Videos

No response

Ngôn ngữ chính
C++
Star
127k
Fork
25.5k
Merge trung bình
3 ngày 22 giờ
Pull request đã merge (30 ngày)
235

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của react/react-native

Tất cả issue của react/react-native

Issue tương tự

Thêm issue về C++

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.