Android: setting a view's background drawable alpha anywhere from 1 to 254 makes its border fully transparent

Đang mở
#59,963 0 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 2 ngày

Chưa có ai nhận issue này.

  • #59965 của @lazerg — đã đóng, không merge

Đánh giá

Độ khó
2/5
Thời gian dự kiến
1-3 giờ
Mức phù hợp với người mới
25/100
Loại issue
Lỗi
Độ rõ ràng
Đặc tả rõ ràng
Mức độ hoạt động
Đình trệ
Công nghệ
android, kotlin, react-native
Lĩnh vực
mobile

Hướng nghiên cứu

Start with BorderDrawable.kt, especially multiplyColorAlpha and the paint and opacity call sites named in the issue; the report links the related earlier change in issue #56154. Check existing Android drawable tests and add coverage for alpha values between 1 and 254, including edge-colored borders. Done means border alpha scales as expected while alpha 0 and 255 retain their current behavior; pull request #59965 is already open.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

Needs: Triage :mag: Platform: Android
Description

On Android, setting a view's background drawable alpha to any value from 1 to 254, as view.background.alpha = 128 from native code, makes its border fully transparent, where it should draw the border at that alpha; the background color takes the alpha as asked, and 0 and 255 behave. The view's CompositeBackgroundDrawable is a LayerDrawable, whose setAlpha hands the alpha to each layer, BorderDrawable among them.

BorderDrawable.multiplyColorAlpha (L1084-L1095) computes colorAlpha * (alpha shr 7) shr 8, with alpha the drawable's alpha mapped to 0..256. alpha shr 7 is 0 below 128 and 1 from 128 up, so the result is 0 for every color alpha. Every border paint goes through it (L262, L392, L539), and so does getOpacity (L139-L165).

#56154 changed this expression among other border changes and was closed without merging.

Steps to reproduce

The reproducer renders three views with an 8 dp red border on a gray background. MainActivity finds the second and the third by their nativeID through ReactFindViewUtil and sets view.background.alpha = 128 on each; the third has blue top, right and bottom edges, so its border is drawn edge by edge.

  1. Clone the reproducer and, with one Android device attached, run ./reproduce.sh. It builds and installs the release APK, waits for MainActivity to log the alpha it set, takes a screenshot and reads the middle of each view's left border edge.
  2. Or by hand: cd ReproducerApp/android && ./gradlew assembleRelease && adb install -r app/build/outputs/apk/release/app-release.apk, and open the app.

Expected: the second and the third view draw their border at half its alpha, as they draw their background; alpha 0 and 255 draw the border as they do now.
Seen: neither draws any border.

React Native Version

0.90.0-nightly-20261112-897cca827

Affected Platforms

Runtime - Android

Output of npx @react-native-community/cli info
System:
  OS: Windows 11 10.0.26300
  CPU: "(32) x64 AMD Ryzen 9 9950X3D 16-Core Processor          "
  Memory: 120.39 GB / 255.67 GB
Binaries:
  Node:
    version: 26.12.1
    path: C:\Program Files\nodejs\node.EXE
  Yarn:
    version: 1.22.22
    path: C:\Users\<user>\AppData\Roaming\npm\yarn.CMD
  npm:
    version: 12.2.1
    path: C:\Program Files\nodejs\npm.CMD
  Watchman: Not Found
SDKs:
  Android SDK: Not Found
  Windows SDK:
    AllowDevelopmentWithoutDevLicense: Enabled
    Versions:
      - 10.0.19041.0
      - 10.0.26100.0
IDEs:
  Android Studio: AI-262.9437.185.2621.16467767
  Visual Studio: Not Found
Languages:
  Java:
    version: 17.0.20.1
    path: C:\Program Files\Microsoft\jdk-17.0.20.101-hotspot\bin\javac.EXE
  Ruby: Not Found
npmPackages:
  "@react-native-community/cli":
    installed: 21.0.0-alpha.1
    wanted: 21.0.0-alpha.1
  react:
    installed: 19.3.0
    wanted: 19.3.0
  react-native:
    installed: 0.90.0-nightly-20261112-897cca827
    wanted: 0.90.0-nightly-20261112-897cca827
  react-native-windows: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: true
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found
Stacktrace or Logs

No error is logged. ./reproduce.sh at the reproducer's 465c5d4, on a Galaxy S23:

device: SM-S911B, Android 14 (API 34), arm64-v8a, 1080x2340 at 480 dpi
react-native 0.90.0-nightly-20261112-897cca827
== ./gradlew :app:assembleRelease -PreactNativeArchitectures=arm64-v8a
BorderAlphaReproducer: uniform-border: CompositeBackgroundDrawable.alpha = 128
BorderAlphaReproducer: edge-colors: CompositeBackgroundDrawable.alpha = 128
screenshot: screenshots/background-alpha-128.png
red border, background alpha untouched: left border edge rgb(255, 0, 0)
red border, background alpha 128: left border edge rgb(206, 206, 206), red border alpha 0, where 128 is half
red left edge, background alpha 128: left border edge rgb(206, 206, 206), red border alpha 0, where 128 is half
SUMMARY: with view.background.alpha = 128, the red border and the red left edge are gone, where each should show at half its alpha
MANDATORY Reproducer

https://github.com/YevheniiKotyrlo/rn-background-alpha-erases-border

Screenshots and Videos

The reproducer on the Galaxy S23:

Ngôn ngữ chính
C++
Star
127k
Fork
25.5k
Merge trung bình
3 ngày 22 giờ
Pull request đã merge (30 ngày)
235

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của react/react-native

Tất cả issue của react/react-native

Issue tương tự

Thêm issue về C++

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.