OAuth discovery drops explicit default ports from advertised issuer identifiers

Đang mở
  • Có gì không ổn?
#1,420 2 bình luận 0 reaction 1 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 2 ngày

@gocamille đang làm issue này rồi.

Từ ngày 31/10/2026.

Đánh giá

Issue này chưa được đánh giá.

Mô tả

bug P1 ready for work T-security T-transport

Summary

OAuth discovery rejects internally consistent metadata when the advertised authorization-server issuer contains an explicit default port, such as https://auth.example.com:443/tenant1.

The original identifier is parsed into a Url, which removes :443. The serialized URL is then used as the expected issuer, while AuthorizationMetadata.issuer retains the original JSON string.

Reproduced against main at c742b5536724ec376b14b7ddcbbd024b7d6ae163 (rmcp 3.8.0). The same code is present at 98a54789b80110ad210495c4ad845c89e1980471, the rmcp revision pinned by Codex 0.166.0.

Reproduction with simulated metadata

Using the existing RecordingOAuthHttpClient test helper, return these responses during AuthorizationManager::resolve_metadata():

  1. An initial 401 for the MCP resource https://mcp.example.com/.
  2. Protected resource metadata:
{
  "resource": "https://mcp.example.com/",
  "authorization_servers": ["https://auth.example.com:443/tenant1"]
}
  1. Authorization-server metadata:
{
  "issuer": "https://auth.example.com:443/tenant1",
  "authorization_endpoint": "https://auth.example.com/tenant1/authorize",
  "token_endpoint": "https://auth.example.com/tenant1/token"
}

No real OAuth credentials or external service are needed.

Expected: discovery accepts the metadata because its issuer exactly matches the identifier advertised by protected resource metadata.

Actual:

Authorization server issuer mismatch: expected https://auth.example.com/tenant1, received https://auth.example.com:443/tenant1

Root cause

In crates/rmcp/src/transport/auth.rs, authorization_metadata_from_resource_metadata() parses the candidate with Url::parse(candidate), then calls:

.try_discover_oauth_server(&candidate_url, Some(candidate_url.as_str()))

candidate_url.as_str() has already lost the explicit default port. Parsing is appropriate for transport, but its normalized output no longer represents the original OAuth identifier.

This also creates an asymmetric check: an advertised issuer containing :443 can incorrectly match metadata that omits it, because the expected value has been normalized first.

Relation to #1144 / #1145

#1145 preserves the issuer through discovery to address the trailing-slash problem in #1144, but retains the parsed URL representation. That preserves a tenant's trailing slash while still losing an explicit default port and host casing.

I did not find an existing issue specifically covering this default-port case. #1268 concerns HTTP Origin validation and is a separate problem.

Proposed approach

Preserve the advertised absolute issuer string for identity validation, separately from the parsed URL used to construct discovery requests. Keep the existing resolved-URL behavior for legacy relative references.

The fix should not normalize both issuers or treat identifiers with and without :443 as interchangeable. RFC 8414 sections 3.3 and 4 require validation against the original issuer identifier.

Local validation and question

A local candidate fix has mocked regression coverage for matching and mismatched default ports, nonstandard ports, host casing, tenant paths and trailing slashes, including the complete metadata discovery path. A before/after comparison of OAuth and HTTP tests found no new failures; full upstream CI has not been run.

Would preserving the original advertised identifier be an appropriate follow-up to #1145 before submitting a PR?

AI assistance was used for the investigation and local regression tests. All examples above use fictional domains and tenants.

Ngôn ngữ chính
Rust
Star
4.1k
Fork
694
Merge trung bình
3 ngày 14 giờ
Pull request đã merge (30 ngày)
39

Chuẩn bị môi trường

Mở trong Codespaces

Khởi chạy dev container của dự án ngay trên trình duyệt, bằng tài khoản GitHub của bạn.

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của modelcontextprotocol/rust-sdk

Tất cả issue của modelcontextprotocol/rust-sdk

Issue tương tự

Thêm issue về Rust

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.