Kaui: evaluate enabling JRuby invokedynamic (setenv.sh hard-codes -Djruby.compile.invokedynamic=false)

Đang mở
#349 1 bình luận 0 reaction 1 người được giao Xem trên GitHub

@tungleduyxyz đang làm issue này rồi.

Từ ngày 4/11/2026.

Đánh giá

Issue này chưa được đánh giá.

Mô tả

perf

Summary

The shared Tomcat setenv.sh template turns JRuby's invokedynamic support off for every image built from it, Kaui included. A JRuby performance team recommends turning it on:

Method profiles end up being heavily polluted by non-indy method call logic, including some places that appear to be polymorphic and could benefit from the indy logic's polymorphic cache. [...] it will improve the quality of the profiles and it should perform better (if it does not then that's what we need to investigate, because it blows non-indy away on smaller stuff).

Where

ansible/templates/tomcat/conf/setenv.sh.j2#L35 (same line on master and java2x):

-Djruby.compile.invokedynamic=false
  • The base image is shared by the Kill Bill and Kaui images. The setting was probably added for Kill Bill's JRuby plugins; it isn't documented why.
  • It is present on the Java 21 / Tomcat 11 perf server, running Kill Bill 0.25.5 + Kaui 4.0.26 / JRuby 10.0.6.0 (checked on the running JVM's command line).
  • Kaui can override it without touching Kill Bill: ansible/templates/kaui/conf/setenv2.sh.j2 appends {{ kaui_system_properties }} to CATALINA_OPTS after setenv.sh, and for a repeated -D the JVM uses the last value.

Relationship with the JIT login bug

The Kaui login bug (killbill/killbill-admin-ui-standalone#131) happens with invokedynamic on and off. It is a JIT bug in JRuby 10.0.x, fixed in 10.1.1.0+ (see killbill/killbill-admin-ui-standalone#133). So enabling indy is not blocked by it, as long as the current workaround (-Djruby.jit.exclude=Rails::Engine#call, killbill/killbill-cloud#346) or JRuby 10.1.1+ is in place.

Plan

  1. Experiment on the perf server, Kaui only: add -Djruby.compile.invokedynamic=true (keeping the jit.exclude workaround).
  2. Run the same Gatling scenarios as the baseline (killbill-admin-ui-standalone perf/, 10 users, 600 s), after warm-up: indy usually costs more at startup/warm-up and pays off once warm. Capture JFR for each run.
  3. Compare with the baseline below. Check method profiles (less call-site overhead), allocation, p75/p95/p99, and warm-up time.
  4. If it's better, change the default for the Kaui image only (via kaui_system_properties or the Kaui setenv2.sh.j2). Kill Bill's setting stays as is unless the Kill Bill team wants to evaluate it too.

Baseline (indy off, G1, shared Kill Bill + Kaui JVM on a t2.medium):

Scenario p75 p95 p99
realistic mix 1,097 ms 1,978 ms —
account_show — 331 ms —
timeline 292 ms 1,601 ms 2,533 ms

Acceptance criteria

  • Before/after Gatling results and JFR recordings with indy on vs off (same instance, same data, after warm-up)
  • Decision recorded; if positive, the Kaui image/role defaults to -Djruby.compile.invokedynamic=true, and the reason for keeping (or changing) Kill Bill's setting is documented in setenv.sh.j2

Related

  • killbill/killbill-admin-ui-standalone#131 / #133: JIT login bug and the JRuby 10.1 upgrade
  • killbill/killbill-cloud#346: the jit.exclude workaround
  • killbill/killbill-cloud#344: Tomcat 11 / JDK 21
  • killbill/killbill-client-ruby#125, #126 and killbill/killbill-admin-ui-standalone#136: the other items from the same profiling round
Ngôn ngữ chính
Ruby
Star
68
Fork
93
Merge trung bình
1 ngày 13 giờ
Pull request đã merge (30 ngày)
4

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của killbill/killbill-cloud

Tất cả issue của killbill/killbill-cloud

Issue tương tự

Thêm issue về Ruby

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.