Kaui: evaluate enabling JRuby invokedynamic (setenv.sh hard-codes -Djruby.compile.invokedynamic=false)

オープン
#349 コメント 1 件 リアクション 0 件 担当者 1 名 GitHub で見る

@tungleduyxyz がすでに取り組んでいます。

2026年11月4日 から。

評価

この issue はまだ評価されていません。

説明

perf

Summary

The shared Tomcat setenv.sh template turns JRuby's invokedynamic support off for every image built from it, Kaui included. A JRuby performance team recommends turning it on:

Method profiles end up being heavily polluted by non-indy method call logic, including some places that appear to be polymorphic and could benefit from the indy logic's polymorphic cache. [...] it will improve the quality of the profiles and it should perform better (if it does not then that's what we need to investigate, because it blows non-indy away on smaller stuff).

Where

ansible/templates/tomcat/conf/setenv.sh.j2#L35 (same line on master and java2x):

-Djruby.compile.invokedynamic=false
  • The base image is shared by the Kill Bill and Kaui images. The setting was probably added for Kill Bill's JRuby plugins; it isn't documented why.
  • It is present on the Java 21 / Tomcat 11 perf server, running Kill Bill 0.25.5 + Kaui 4.0.26 / JRuby 10.0.6.0 (checked on the running JVM's command line).
  • Kaui can override it without touching Kill Bill: ansible/templates/kaui/conf/setenv2.sh.j2 appends {{ kaui_system_properties }} to CATALINA_OPTS after setenv.sh, and for a repeated -D the JVM uses the last value.

Relationship with the JIT login bug

The Kaui login bug (killbill/killbill-admin-ui-standalone#131) happens with invokedynamic on and off. It is a JIT bug in JRuby 10.0.x, fixed in 10.1.1.0+ (see killbill/killbill-admin-ui-standalone#133). So enabling indy is not blocked by it, as long as the current workaround (-Djruby.jit.exclude=Rails::Engine#call, killbill/killbill-cloud#346) or JRuby 10.1.1+ is in place.

Plan

  1. Experiment on the perf server, Kaui only: add -Djruby.compile.invokedynamic=true (keeping the jit.exclude workaround).
  2. Run the same Gatling scenarios as the baseline (killbill-admin-ui-standalone perf/, 10 users, 600 s), after warm-up: indy usually costs more at startup/warm-up and pays off once warm. Capture JFR for each run.
  3. Compare with the baseline below. Check method profiles (less call-site overhead), allocation, p75/p95/p99, and warm-up time.
  4. If it's better, change the default for the Kaui image only (via kaui_system_properties or the Kaui setenv2.sh.j2). Kill Bill's setting stays as is unless the Kill Bill team wants to evaluate it too.

Baseline (indy off, G1, shared Kill Bill + Kaui JVM on a t2.medium):

Scenario p75 p95 p99
realistic mix 1,097 ms 1,978 ms —
account_show — 331 ms —
timeline 292 ms 1,601 ms 2,533 ms

Acceptance criteria

  • Before/after Gatling results and JFR recordings with indy on vs off (same instance, same data, after warm-up)
  • Decision recorded; if positive, the Kaui image/role defaults to -Djruby.compile.invokedynamic=true, and the reason for keeping (or changing) Kill Bill's setting is documented in setenv.sh.j2

Related

  • killbill/killbill-admin-ui-standalone#131 / #133: JIT login bug and the JRuby 10.1 upgrade
  • killbill/killbill-cloud#346: the jit.exclude workaround
  • killbill/killbill-cloud#344: Tomcat 11 / JDK 21
  • killbill/killbill-client-ruby#125, #126 and killbill/killbill-admin-ui-standalone#136: the other items from the same profiling round
主要言語
Ruby
スター
68
フォーク
93
平均マージ
1日 13時間
マージ済み PR(30日)
4

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

killbill/killbill-cloud のほかの issue

killbill/killbill-cloud の issue をすべて見る

似ている issue

Ruby の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。