bug: ion-modal sheets presented back to back overflow the call stack

Đang mở
#31,757 1 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

Chưa có ai nhận issue này.

Đánh giá

Độ khó
3/5
Thời gian dự kiến
1-2 ngày
Mức phù hợp với người mới
72/100
Loại issue
Lỗi
Độ rõ ràng
Đặc tả rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
javascript, typescript, web-dev
Lĩnh vực
accessibility, frontend

Hướng nghiên cứu

Read core/src/components/modal/modal.tsx, especially onModalFocus around lines 1225-1236, and the overlay focus trap in core/src/utils/overlays.ts. Reproduce the stack overflow by presenting two sheet modals back to back, then check how the topmost overlay is identified. Done when the lower modal no longer moves focus to its drag handle and the reproduction no longer overflows the call stack.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

package: core type: bug
Prerequisites
  • I have read the Contributing Guidelines.
  • I agree to follow the Code of Conduct.
  • I have searched for existing issues that already report this problem, without success.
Ionic Framework Version

v9.x, Nightly

Current Behavior

When a second sheet modal is presented before the first sheet's present() has resolved, the page throws RangeError: Maximum call stack size exceeded and the UI stops responding.

The loop runs like this:

  1. When the first modal's enter animation ends, it focuses its wrapper. The second modal is already the topmost overlay.
  2. The overlay focus trap (trapShadowFocus in core/src/utils/overlays.ts, a capture listener on document) sees focus outside the topmost overlay. The second modal has no element that matches focusableQueryString, so the trap focuses the second modal's host synchronously.
  3. The first modal's onModalFocus (core/src/components/modal/modal.tsx, lines 1225-1236 on main) sees its host focused with no focused element in its shadow root, and calls dragHandleEl.focus() (line 1234). In v9 every sheet has a focusable handle, because handleBehavior defaults to cycle.
  4. The trap moves focus back to the second modal, and steps 3 and 4 repeat until the call stack overflows.

If the second modal contains a radio group, the trap focuses it through the async setFocus(), and the loop does not start. The guard added in #31293 (shadowRoot.activeElement == null) does not stop this case, because the host itself is focused and nothing inside it is.

Stack (Chromium, 9.0.10, unminified build):

RangeError: Maximum call stack size exceeded.
    at focusVisibleElement (helpers.js:165:6)
    at focusElementInContext (overlays.js:124:7)
    at focusFirstDescendant (overlays.js:106:3)
    at trapShadowFocus (overlays.js:239:7)
    at trapKeyboardFocus (overlays.js:247:5)
    at HTMLDocument.<anonymous> (overlays.js:256:7)

Results from the reproduction, 20 headless Playwright runs per cell:

@ionic/core Chromium WebKit
9.0.10 20 of 20 18 of 20
9.0.11 20 of 20 19 of 20
9.0.12-nightly.20261116 20 of 20 20 of 20
Expected Behavior

Presenting a second sheet before the first sheet has finished presenting does not loop. A modal that is not the topmost overlay does not move focus to its own drag handle while the focus trap moves focus into the overlay above it.

Steps to Reproduce
  1. Clone the reproduction, then run npm install and npx vite.
  2. Open the page and the browser console.
  3. Tap Present both. It calls first.present() without awaiting it, then calls second.present().
  4. The console shows RangeError: Maximum call stack size exceeded.
Code Reproduction URL

https://github.com/srobroek/ionic-sheet-focus-repro

Ionic Info

The reproduction uses @ionic/core only, with no framework, built with Vite 7.

Ionic CLI       : 7.2.1
@ionic/core     : 9.0.10 (also tested 9.0.11 and 9.0.12-nightly.20261116)
NodeJS          : v24.22.0
npm             : 11.19.1
OS              : Linux 6.12
Browsers        : Playwright 1.65.0 Chromium and WebKit, headless
Additional Information

Possible fix: in onModalFocus, call dragHandleEl.focus() only when this modal is the topmost presented overlay, for example when getPresentedOverlay(document, 'ion-modal') === this.el (core/src/utils/overlays.ts, line 481).

Workaround: a capture-phase focus listener on document.documentElement that calls stopPropagation() when the event target is an ion-modal that is not document.activeElement. The reproduction includes it behind ?guard=1, and with it the error occurred in 0 of 20 runs on each version in Chromium.

Related: #24491 is an older focus trap recursion with stacked overlays, fixed in #24611. #31293 added the host-focus guard in onModalFocus.

This issue and the reproduction were prepared with the help of an AI assistant. I verified that the reproduction triggers the error and that the workaround removes it.

Ngôn ngữ chính
TypeScript
Star
52.8k
Fork
13.3k
Merge trung bình
3 ngày 1 giờ
Pull request đã merge (30 ngày)
78

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của ionic-team/ionic-framework

Tất cả issue của ionic-team/ionic-framework

Issue tương tự

Thêm issue về TypeScript

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.