bug: ion-modal sheets presented back to back overflow the call stack
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 72/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- javascript, typescript, web-dev
- Ambito
- accessibility, frontend
Direzione di ricerca
Read core/src/components/modal/modal.tsx, especially onModalFocus around lines 1225-1236, and the overlay focus trap in core/src/utils/overlays.ts. Reproduce the stack overflow by presenting two sheet modals back to back, then check how the topmost overlay is identified. Done when the lower modal no longer moves focus to its drag handle and the reproduction no longer overflows the call stack.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Prerequisites
- I have read the Contributing Guidelines.
- I agree to follow the Code of Conduct.
- I have searched for existing issues that already report this problem, without success.
Ionic Framework Version
v9.x, Nightly
Current Behavior
When a second sheet modal is presented before the first sheet's present() has resolved, the page throws RangeError: Maximum call stack size exceeded and the UI stops responding.
The loop runs like this:
- When the first modal's enter animation ends, it focuses its wrapper. The second modal is already the topmost overlay.
- The overlay focus trap (
trapShadowFocusincore/src/utils/overlays.ts, a capture listener ondocument) sees focus outside the topmost overlay. The second modal has no element that matchesfocusableQueryString, so the trap focuses the second modal's host synchronously. - The first modal's
onModalFocus(core/src/components/modal/modal.tsx, lines 1225-1236 onmain) sees its host focused with no focused element in its shadow root, and callsdragHandleEl.focus()(line 1234). In v9 every sheet has a focusable handle, becausehandleBehaviordefaults tocycle. - The trap moves focus back to the second modal, and steps 3 and 4 repeat until the call stack overflows.
If the second modal contains a radio group, the trap focuses it through the async setFocus(), and the loop does not start. The guard added in #31293 (shadowRoot.activeElement == null) does not stop this case, because the host itself is focused and nothing inside it is.
Stack (Chromium, 9.0.10, unminified build):
RangeError: Maximum call stack size exceeded.
at focusVisibleElement (helpers.js:165:6)
at focusElementInContext (overlays.js:124:7)
at focusFirstDescendant (overlays.js:106:3)
at trapShadowFocus (overlays.js:239:7)
at trapKeyboardFocus (overlays.js:247:5)
at HTMLDocument.<anonymous> (overlays.js:256:7)
Results from the reproduction, 20 headless Playwright runs per cell:
@ionic/core |
Chromium | WebKit |
|---|---|---|
| 9.0.10 | 20 of 20 | 18 of 20 |
| 9.0.11 | 20 of 20 | 19 of 20 |
| 9.0.12-nightly.20261116 | 20 of 20 | 20 of 20 |
Expected Behavior
Presenting a second sheet before the first sheet has finished presenting does not loop. A modal that is not the topmost overlay does not move focus to its own drag handle while the focus trap moves focus into the overlay above it.
Steps to Reproduce
- Clone the reproduction, then run
npm installandnpx vite. - Open the page and the browser console.
- Tap Present both. It calls
first.present()without awaiting it, then callssecond.present(). - The console shows
RangeError: Maximum call stack size exceeded.
Code Reproduction URL
https://github.com/srobroek/ionic-sheet-focus-repro
Ionic Info
The reproduction uses @ionic/core only, with no framework, built with Vite 7.
Ionic CLI : 7.2.1
@ionic/core : 9.0.10 (also tested 9.0.11 and 9.0.12-nightly.20261116)
NodeJS : v24.22.0
npm : 11.19.1
OS : Linux 6.12
Browsers : Playwright 1.65.0 Chromium and WebKit, headless
Additional Information
Possible fix: in onModalFocus, call dragHandleEl.focus() only when this modal is the topmost presented overlay, for example when getPresentedOverlay(document, 'ion-modal') === this.el (core/src/utils/overlays.ts, line 481).
Workaround: a capture-phase focus listener on document.documentElement that calls stopPropagation() when the event target is an ion-modal that is not document.activeElement. The reproduction includes it behind ?guard=1, and with it the error occurred in 0 of 20 runs on each version in Chromium.
Related: #24491 is an older focus trap recursion with stacked overlays, fixed in #24611. #31293 added the host-focus guard in onModalFocus.
This issue and the reproduction were prepared with the help of an AI assistant. I verified that the reproduction triggers the error and that the workaround removes it.
- Lingua principale
- TypeScript
- Stelle
- 52.8k
- Fork
- 13.3k
- Merge medio
- 3g 1h
- PR unite (30g)
- 78
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di ionic-team/ionic-framework
-
bug: input-otp, backspace in an empty box only moves focus instead of clearing the previous boxForse già presa @sarankumar1325 l’ha presa 24 giorni fa. Apertapackage: core type: bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 90/100
ionic-team/ionic-framework#31639 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
bug: vue swipe cancellation throws when the previous page is missingForse già presa @dandoingdev l’ha presa 47 giorni fa. Apertapackage: vue type: bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
ionic-team/ionic-framework#31514 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
bug: ion-searchbar input is always labelled "search text"; aria-label on the host is not forwardedForse già presa @HappyKnuckles l’ha presa 41 giorni fa. Apertaa11y package: core type: bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
ionic-team/ionic-framework#31492 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
bug: IonTabs throws when a Fragment contains one IonRouterOutletForse già presa @Benziza l’ha presa 82 giorni fa. Apertapackage: react type: bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
ionic-team/ionic-framework#31410 · 2 commenti ·
I maintainer di solito rispondono entro 1 giorno
-
bug: angular swipe-back gesture crashes in StackController.startBackTransition when the stack is popped before the gesture is capturedForse già presa @officialasishkumar l’ha presa 10 giorni fa. Apertapackage: angular type: bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 86/100
ionic-team/ionic-framework#31291 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di ionic-team/ionic-framework
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
vercel-labs/ui#809 ·
I maintainer di solito rispondono entro 1 giorno
-
bot:ai-assisted component:platform-js status:untriaged
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 74/100
midnightntwrk/platform-js#38 ·
-
[bug] Second false positive on high-cost plugin alert: detection only compares patch entry id, community plugin dsh-auto | [bug] 高成本插件告警第二次误报:检测只比对 patch 条目 id,社区插件 dsh-auto-review 被认成 @deepseek-ai/dsh-experimental-auto-reviewForse già presa Una pull request collegata a questa issue è aperta o già unita. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
ranxianglei/billion-context#7068 ·
I maintainer di solito rispondono entro 1 giorno
-
vendor: bump whisper.cpp past 6a8addd — the current pin aborts the app on a failed Metal initAperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
mybigday/whisper.rn#348 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
six-group/six-webcomponents#600 ·