Source collection emptied when an ordered window that fell back to a full-source read is replaced by one reading the same subset

Đang mở
  • Có gì không ổn?
#2,353 0 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

Chưa có ai nhận issue này.

Đánh giá

Độ khó
4/5
Thời gian dự kiến
3-5 ngày
Mức phù hợp với người mới
48/100
Loại issue
Lỗi
Độ rõ ràng
Đặc tả rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
typescript
Lĩnh vực
database

Hướng nghiên cứu

Start with repro.test.ts in the linked reproduction to see the failing subscribe and release sequence, then trace ordered-window fallback and source collection cleanup in the TanStack DB code. Reproduce with npm test; done means switching between overlapping full-source fallback windows keeps the 50-row window populated and the shared source rows intact, regardless of subscribe and release order.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

  • I've validated the bug against the latest version of DB packages

Describe the bug

One syncMode: "on-demand" query collection, one ordered, limited live query:

q.from({ r: source })
  .where(({ r }) => not(eq(r.status, 4)))
  .orderBy(({ r }) => r.date, { direction, nulls, stringSort: "lexical" })
  .orderBy(({ r }) => r.id, direction)
  .limit(50)

When the sort direction changes, the new live query is subscribed, then the old one is released (what a UI binding does when a reactive sort changes). If both windows fell back to a full-source read of the same filter, releasing the old window removes every row from the source collection. The new window stays at 0 rows and never recovers, nor does any other view on that collection.

Two triggers of the documented full-source fallback reproduce it:

  • the first page ends on a NULL sort value (DESC NULLS FIRST on a nullable column);
  • stringSort: "locale", without any NULL.

Indexes matching the query's compareOptions (no dev warning) don't change the result.

Requests seen by queryFn in the failing case:

DESC  limit=50    -> 50 rows
DESC  limit=none  -> 240 rows   (full-source fallback, where: status != 4)
ASC   limit=50    -> 50 rows
ASC   limit=none  -> 240 rows   (same subset as above)
-- old DESC window released --
source.size === 0, asc.size === 0

Controls that work:

  • No NULL dates: the DESC window only requests its boundary tie (date = …), so the ASC full read is a different subset. The source keeps 240 rows.
  • Same NULL data, but the old window is released before the new one subscribes: the source keeps its rows and the ASC window shows 50.
  • Two unordered live queries with the same where, overlapping the same way, keep their rows. So it seems specific to subsets acquired by the ordered loader's full-source fallback.

To Reproduce

Repo: https://github.com/1bod/tanstack-db-ordered-window-empties-source
StackBlitz: https://stackblitz.com/github/1bod/tanstack-db-ordered-window-empties-source

  1. npm install
  2. npm test
  3. See the 2 control tests pass and the 3 BUG tests fail with expected +0 to be 50 (window) and expected 0 to be greater than 0 (source collection size).

repro.test.ts only uses @tanstack/db, @tanstack/query-db-collection and @tanstack/query-core, with a fake backend that honours where (including cursor predicates), orderBy with NULLS FIRST/LAST, offset and limit.

Expected behavior

After the switch, the ASC window shows its 50 rows and the source collection keeps the rows the new window holds, whatever the order of subscribe and release.

Screenshots

N/A

Desktop (please complete the following information):

  • OS: Linux
  • Browser: N/A (Node 26.13, vitest 4.1.12). First seen in a browser with @tanstack/vue-db (useLiveQuery / useLiveInfiniteQuery) when toggling the sort of a list sorted by a nullable date.
  • Version: @tanstack/db 1.0.0-rc.1.3, @tanstack/query-db-collection 1.5.1, @tanstack/query-core 5.105.3

Smartphone (please complete the following information):

N/A

Additional context

Workaround: split the query into an isNull(date) window and a not(isNull(date)) window with stringSort: "lexical", so no page ends on NULL and the fallback never runs.

Possibly related: #2160 (rows lost across reentrant final-owner cleanup), #2352 (identical subset reuse), #2268 (full-source fallback on NULL page ends).

Ngôn ngữ chính
TypeScript
Star
4k
Fork
277
Merge trung bình
1 ngày 9 giờ
Pull request đã merge (30 ngày)
162

Chuẩn bị môi trường

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của TanStack/db

Tất cả issue của TanStack/db

Issue tương tự

Thêm issue về TypeScript

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.