Audit the remaining deferred ESLint rules and document justified exceptions

Đang mở
#9,503 0 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 1 ngày

Chưa có ai nhận issue này.

Đánh giá

Độ khó
5/5
Thời gian dự kiến
Hơn một tuần
Mức phù hợp với người mới
8/100
Loại issue
Tái cấu trúc
Độ rõ ràng
Khá rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
eslint, javascript
Lĩnh vực
developer-experience

Hướng nghiên cứu

Start with the effective rule configuration in eslint.config.mjs and the .editorconfig tab convention, then check the cited files src/components/PdfEditor/Signature.vue and src/views/Settings/ConfigureCheck.vue, where v-html renders row.message. Done means one decision record per rule (enable, defer with a dependency, or intentionally disable with a justification) backed by a fresh lint inventory on the base SHA, plus a review of #9498-#9502 and PR #9497 on main. This needs maintainer policy decisions, so it is not a first-timer task.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

frontend javascript technical debt

Goal

Make an evidence-based, maintainable decision about the 16 remaining deferred ESLint rules not covered by #9498-#9502. This is a technical classification and final handoff, not a mass-refactor task.

Rules in scope

  • Translations: @nextcloud/l10n-enforce-ellipsis, @nextcloud/l10n-non-breaking-space.
  • Vue/API contracts: vue/attribute-hyphenation, vue/custom-event-name-casing, vue/slot-name-casing, vue/v-on-event-hyphenation, vue/no-v-html, vue/multi-word-component-names, camelcase.
  • Indentation: @stylistic/indent, @stylistic/no-tabs.
  • Documentation: jsdoc/require-jsdoc, jsdoc/require-param, jsdoc/require-param-description.
  • Other: antfu/top-level-function, vue/no-unused-properties.

Evidence to collect

  1. Capture base SHA and a fresh current lint inventory for every rule; include effective preset options and affected files. Existing eslint.config.mjs hit counts are historical.
  2. Classify each rule as enable now, defer with a stated dependency, or intentionally disabled with a technical justification. Record evidence, tradeoffs, affected contracts, test strategy and accountable maintainer decision.
  3. Verify examples before deciding: .editorconfig requires tabs, so @stylistic/no-tabs conflicts with the current project convention; src/components/PdfEditor/Signature.vue emits onUpdate/onDelete; src/views/Settings/ConfigureCheck.vue uses v-html on row.message; the policy catalog uses HTML highlighting with explicit escaping. Do not assume these all have the same risk or that changing names is harmless.
  4. Avoid dummy JSDoc comments and cosmetic renames of Vue events, slots or backend/API field names. Treat translation strings and generated artifacts as protected boundaries.
  5. Review the final implementation results of #9498-#9502 and PR #9497 against the actual integrated main, including lint/type/build/test checks; do not infer success from closed issue counts.
  6. If the audit finds further independent implementation deliverables, propose them for separate approval rather than quietly expanding the task or closing the epic prematurely. Report security-sensitive HTML findings through the appropriate private disclosure process when needed.

Deliverable / acceptance criteria

  • One per-rule decision record for all 16 rules, with current measured evidence and relevant contracts.
  • Decisions are explicitly reviewed for Vue/API/translation/security impacts; unresolved decisions are not labeled complete.
  • Justified intentional disables have concise, non-stale explanations near the effective configuration.
  • Integrated checks on main have been verified or report the exact blocker.
  • The epic's final acceptance criteria can be judged without relying solely on a 100% sub-issue counter.

Out of scope and contributor suitability

Do not mass-change runtime code, Vue event names, API fields, translations or indentation while producing this audit. The work requires policy and architecture decisions; keep it available for maintainers/experienced contributors, not good first issue.

Additional context

Development workflow: https://docs.libresign.coop/developer_manual/development-workflow.html
Questions: https://t.me/LibreSign

Ngôn ngữ chính
PHP
Star
844
Fork
176
Merge trung bình
14 giờ 3 phút
Pull request đã merge (30 ngày)
344

Chuẩn bị môi trường

Mở trong Codespaces

Khởi chạy dev container của dự án ngay trên trình duyệt, bằng tài khoản GitHub của bạn.

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của LibreSign/libresign

Tất cả issue của LibreSign/libresign

Issue tương tự

Thêm issue về PHP

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.