Enrich the club pages with club info that only the index or the iOS app shows

Open
#277 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
html, swift

Research direction

Start by reading Level2Pages and Members.hasMembersPage, which the issue identifies as controlling club page generation, then trace how club data is localized and rendered in the generated pages. The payload names #275 as the map sub-issue and #276 for canonical URLs and the sitemap; check those alongside generation time before changing page generation. Done means every club has a page in every generated language, the chosen club details and localized labels appear, and clubs with zero or one member get next-step instructions.

Written by the indexing model from the issue text.

Description

Enhancement

Why

A tester of the iOS app expects one page per club that holds everything worth knowing about that club, and a tap on a club to lead there. The generated site already has a page per club (Members, in Ignite/Level 2/), but it shows less than the iOS app and less than the clubs index. Making that page richer is the first of two steps towards that expectation. It is easy to defend because it does not change the site's structure.

Step 1 (this ticket): enrich the existing club page

Add to each club's page the club info that today appears only on the /clubs index (OrganizationsPage) or only in the iOS app:

  • a map with the club's pin: #275 (interactive Leaflet map; it is a sub-issue of this ticket)
  • link to the club's website
  • Fotobond club number (membership of the Fotobond)
  • town and country, localized, instead of the town only in the title
  • from the iOS Maps card: the Wikipedia link and the localized remark (about one sentence)
  • the member count as the index shows it (current members only), next to the existing counts

Not every item has to be done. The tables below show what exists where, so that each item can be decided on its own. Related ticket: #273 (exhibitions on the club page).

Decision (27 Oct 2026): a page for every club

Today Level2Pages generates a club page only for clubs that pass Members.hasMembersPage: at least one current member, or a former one when "show former members" is on. That is about 15 of the 147 clubs. The index lists all clubs and links only those. Decision: generate a page for every club, with or without member data. That is about 147 clubs × 2 languages, so about 300 club pages.

Arguments for, in order of weight:

  • Without it, about 90% of clubs would get none of the enrichment above. Their map, website, Fotobond number, Wikipedia link and remark would stay on the index or in the iOS app.
  • A club without members gets a place for non-member data, and for instructions on the next step: whom to contact, what to read, what to supply. The iOS tickets about claiming a club (vdhamer/Photo-Club-Hub#832), joining without a club (#838) and consent for scraped data (#840) all need somewhere to point to.
  • The iOS Maps tab shows every club. If a tap on a card ever leads to a web or club page, every card needs a destination.

Consequences to handle:

  • Members.hasMembersPage no longer decides whether a page exists. Its remaining job is what the index links and shows, and whether the page has a member table.
  • A page without members keeps the "Current members of …" section (in Dutch "Huidige leden van …") with its heading and an empty table, so every club page has the same structure. Below it come instructions for when the table has no members or just one: what does not work, and how to fix it. The exact wording, and whether it links to documentation or to the iOS tickets #832 and #840, is still open. The member count says how far a club has come:
    • 0 members: there is no contact with the club at all. This is the vast majority of clubs.
    • 1 member: we have the name of a contact person.
    • 2 members: only the Template clubs, which have two for demo purposes. They need no instructions.
    • So the instructions apply to 0 and 1, and probably differ between the two.
  • The index names every club as a link. So that "has member data" stays visible, keep the member-count column, blank for clubs without members, and consider making the difference clearer.
  • The site grows from about 15 to about 150 club pages per language. Check generation time, the sitemap, and #276 (canonical URLs and the sitemap).
  • Possible thin-content risk: near-empty pages with the same boilerplate may look like duplicates to Search Console. Each page needs enough club-specific content (name, town, map, website) to differ from its neighbours. Without data this is a judgement, so check Search Console after publishing.
  • Reversing is cheap in the code. On the published site, adding pages is harmless, but removing indexed pages produces 404s.

Step 2 (not in this ticket): reopen the iOS structure

Only after step 1 do we ask whether the iOS app should be restructured. Open questions, none decided:

  • Does iOS get a screen per club, and would that let the Maps card lead there? Maps would then become a hierarchy per country and afdeling, with search leading to a pin.
  • Do the Clubs and Photographers tabs merge, or does each get one screen per item? Hundreds of screens would make searching clubs and people from the second tab a problem.
  • iOS has no person page. Its unit is the portfolio (a person in a club), and one person can have several. A person page would need to group them and to decide where portfolios go: on the person page or behind a separate link.
  • Should we generate portfolio pages ourselves instead of depending on Juicebox or arbitrary existing web pages? There is a ticket for that; it is one of the questionnaire questions.
  • Risk of a web-like structure: users can lose their way when there is no overall structure.

Step 2 will get its own ticket in vdhamer/Photo-Club-Hub. Related there: #256 (markers are not tappable), which the tester's request also touches.

Parked: what is shown where (needs correction)

These tables were compiled by reading the code on 27 Oct 2026, without running either app. They are not entirely correct and must be checked before they are used to decide anything. "?" means not checked.

Club info
Club info iOS Maps card iOS Clubs section HTML /clubs index HTML club (members) page
Full name yes yes (header, with town) yes (links to members page) yes (title badge, with town)
Town and country, localized yes ? (header shows "(town)") yes town only, in the title
Map or coordinates yes no no no
Club website yes no yes (globe link) no
Wikipedia link yes no no no
Remark, ~1 sentence yes no no no
Member count yes (incl. ex-members) yes (footer, "x of y shown") yes (current members only) yes (in the footnotes)
Member list no yes no yes (current and former)
Average membership duration no no no yes
Fotobond club number not shown not shown yes no
Data source (Level 2 URL) no yes (footer) link to the club's JSON on GitHub no
Club or museum both clubs only separate tables clubs only

Not seen anywhere: maintainer email, pinned.

Person info

The data model separates Photographer (the person) from MemberPortfolio (the person in one club).

Person info iOS Clubs row iOS People tab HTML members page row
Name yes yes (last, first) yes (links to the portfolio)
Expertises yes ? yes (links to expertise pages)
Personal website no yes yes
Birthday no yes (only within about a week) no
Deceased yes (name color) yes ("- deceased") yes (badge)
Photo no ? no
Role or status in a club yes (icon and text) yes (text with club name) yes (badges)
Membership years no no yes
Fotobond member number no no yes (in the years line)
Thumbnail of recent work yes yes yes
Portfolio yes (tap opens it) yes yes (name and thumbnail link to the portfolio URL)

The HTML code has no page per person: a member's name links straight to the external portfolio, and the only other pages are the expertise pages. To be verified.

Done when

  • every club has a page in every generated language, whether or not it has member data
  • a club with no members, or just one, shows instructions under its members table on what to do next
  • the items chosen from the list above appear on every club page in every generated language
  • localized strings exist for each new label
  • the tables above are corrected, or removed once they have served their purpose
Dominant language
Swift
Stars
0
Forks
1
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from vdhamer/Photo-Club-Hub-HTML

All issues in vdhamer/Photo-Club-Hub-HTML

Similar issues

More Swift issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.