Tell the maintainer when the data needs a newer Data package
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 72/100
Research direction
Start in Views/WebsiteGeneration.swift and inspect the existing “Website generated” alert, then check how the Data package exposes LevelLoader.newerPackageRequest and the request’s file and version. Add the English and Dutch message in PhotoClubHubHTML.SwiftUI.xcstrings; verify manually with a Level 1 root that requests a newer package and with normal data. Done means the hint appears only for the newer package request and generation still succeeds.
Written by the indexing model from the issue text.
Description
Generator side of vdhamer/Photo-Club-Hub-Data#107, part of vdhamer/Photo-Club-Hub-Data#106. Sibling of
vdhamer/Photo-Club-Hub#899 (iOS).
Why
From iOS 3.0.7 on, the Level 1 club data moves to a new location and file layout in the Data repo. The old tree stays in
place, frozen, and its header carries minimumDataPackageVersion (Data#107). When the Data package this generator was
built with is older than that value, Data still loads the file and logs a warning. After the load,
LevelLoader.newerPackageRequest gives the highest version any file asked for, with the name of a file that asked for
it. Without a message in the generator's window, the maintainer could
generate a site from frozen data and not notice.
Behavior
- When the Data package reports that the data asks for a newer package (
LevelLoader.newerPackageRequestfrom
Data#107), show a message in the generator's UI. Suggested place: one more paragraph in the "Website generated" alert,
next to the existing ⏳ and ⚠️ paragraphs (Views/WebsiteGeneration.swift), since the maintainer already reads that
alert after each run. - The text says what to do: update the Photo Club Hub Data package to the latest version, then generate again. It can
also name the file and the version it asked for (both are in the request), so the maintainer can check them. - Generating still works. The message is a hint, not a block.
- English and Dutch, like the rest of the UI (
PhotoClubHubHTML.SwiftUI.xcstrings). - The warning in the console stays as it is. It is Data's own diagnostic line, not something this ticket relies on.
Testing
Load a Level 1 root whose header has a high minimumDataPackageVersion. How to point the generator at such a root is
part of this ticket. The repo has no test target, so this is a manual check.
Done when
- The message shows after loading such a root.
- Normal data shows no message.
Timing
Needs Data 3.9.0 (Data#107). The package dependency is .upToNextMajor(from: "3.0.0"), so updating packages picks it
up. Ship it before the data move in iOS 3.0.7 (Data#108), so that a generator that missed a package update is told.
- Dominant language
- Swift
- Stars
- 0
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from vdhamer/Photo-Club-Hub-HTML
-
Enhancement Localization
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
vdhamer/Photo-Club-Hub-HTML#242 · 1 comment ·
-
Bug Good first issue Refactoring
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
vdhamer/Photo-Club-Hub-HTML#237 ·
-
Enhancement Ignite
Difficulty 4/5 1-2 days Newbie friendliness 45/100
vdhamer/Photo-Club-Hub-HTML#281 ·
-
Enhancement Ignite
Difficulty 3/5 1-2 days Newbie friendliness 56/100
vdhamer/Photo-Club-Hub-HTML#279 · 1 comment ·
-
Enhancement Ignite
Difficulty 4/5 3-5 days Newbie friendliness 35/100
vdhamer/Photo-Club-Hub-HTML#278 ·
All issues in vdhamer/Photo-Club-Hub-HTML
Similar issues
-
bug documentation
Difficulty 1/5 Under an hour Newbie friendliness 86/100
ajithrnayak/xpunge#7 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
YahiaAngelo/vphone-linux#70 ·
Maintainers usually reply within 1 day
-
follow-up needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
manaflow-ai/cmux#49164 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100