Most pre-processing functions and process_and_segment_image expect 3 dimensions, but percentile_threshold seems to expect 4
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- python
- Domain
- computer-vision, machine-learning
Research direction
Start in model.py at percentile_threshold and histogram_normalization, then compare their documented and actual dimensional assumptions with the other preprocessing functions and process_and_segment_image. Define a consistent expectation for image dimensions and update the affected behavior or documentation so the functions agree.
Written by the indexing model from the issue text.
Description
Most of the functions seem to expect images of 3 dimensions (height, width, channel), but percentile_threshold seems to expect 4, with the first dim being batch.
The documentation for histogram_normalization also references a batch dimension, but I don't think the code actually expects it.
- Dominant language
- Python
- Stars
- 220
- Forks
- 39
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from vanvalenlab/cellSAM
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
vanvalenlab/cellSAM#13 · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 20/100
vanvalenlab/cellSAM#135 ·
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
vanvalenlab/cellSAM#134 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
vanvalenlab/cellSAM#133 · 2 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
vanvalenlab/cellSAM#132 ·
All issues in vanvalenlab/cellSAM
Similar issues
-
bug Triage-Needed
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
FuRongJun-1999/dsh-memory#170 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
521xueweihan/HelloGitHub#3940 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100