Tabs - prevent auto tab activation
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 45/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- angular, bootstrap, typescript
- Domain
- frontend
Research direction
Start with src/tabs/tabset.component.ts, especially the linked code around line 100 that schedules activation of the first available tab. Check how tabset options are defined and tested, then add the requested autoActivateTab option with a default of true and verify that setting it to false prevents the initial activation while preserving the default behavior.
Written by the indexing model from the issue text.
Description
Tabs component automatically activate first available tab: https://github.com/valor-software/ngx-bootstrap/blob/0357a3a7231945a53593d8c795669df460073c99/src/tabs/tabset.component.ts#L100
In most cases this is desired behaviour.
But in my case I have directive that activate tab through reading query param. But it lways activate first tab first and then my directive activate requested in params. My components in tabs are heavy, so I want to prevent unnecessary activation. And even they are light, I want prevent this behaviour to be more clean.
Now I use this hack: Object.assign(this.tabset, { defaultActivationScheduled: true }); and its work.
What I desire:
Add option autoActivateTab with default value true, which can control this case.
- Dominant language
- TypeScript
- Stars
- 5.5k
- Forks
- 1.7k
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from valor-software/ngx-bootstrap
-
Difficulty 1/5 Under an hour Newbie friendliness 86/100
valor-software/ngx-bootstrap#6836 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 69/100
valor-software/ngx-bootstrap#6834 ·
-
comp(pagination)
Difficulty 1/5 Under an hour Newbie friendliness 76/100
valor-software/ngx-bootstrap#6807 · 4 comments · 3 reactions ·
-
Difficulty 1/5 Under an hour Newbie friendliness 67/100
valor-software/ngx-bootstrap#6799 ·
-
Date picker and range picker still accept selection after the form control is disabledPossibly taken @Xapollon430 claimed this 2 days ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 35/100
valor-software/ngx-bootstrap#6839 ·
All issues in valor-software/ngx-bootstrap
Similar issues
-
area: web
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
inabagumi/shinju-date#6823 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
vercel-labs/ui#540 ·
Maintainers usually reply within 1 day
-
accepted ai-dev ai-implementing
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
livesport/homer#218 · 1 comment ·
Maintainers usually reply within 1 day
-
normalizePropName strips `#` characters from Figma property names instead of only the `#id` suffixOpen
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
figma/code-connect#419 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100