Timepicker could add `inputmode="decimal"` attribute

Open Beginner friendly
#6,799 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
67/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Stale
Tech stack
angular, html, typescript

Research direction

Find the timepicker template that renders the minutes input shown in the issue, then check whether related time fields have keyboard hints. Add inputmode="decimal" to the minutes input and verify the rendered input includes that attribute on touchscreen devices. Done when the timepicker exposes the decimal keyboard hint for minutes.

Written by the indexing model from the issue text.

Description

Currently:

<input type="text" maxlength="2" class="form-control text-center bs-timepicker-field" placeholder="MM" aria-label="minutes">

UI would be better for users with virtual keyboards (touchscreen tablets/iPhone/Android etc) with:

<input type="text" maxlength="2" inputmode="decimal" class="form-control text-center bs-timepicker-field" placeholder="MM" aria-label="minutes">

REF: https://css-tricks.com/everything-you-ever-wanted-to-know-about-inputmode/#aa-decimal

Dominant language
TypeScript
Stars
5.5k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from valor-software/ngx-bootstrap

All issues in valor-software/ngx-bootstrap

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.