min-max settings with Timepicker.

Open
#6,744 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
48/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
angular, typescript
Domain
frontend, web-dev

Research direction

Start with the Timepicker min-max example linked in the issue and trace how its hour arrows are disabled when minutes are 00. Reproduce the reported behavior with minTime 08:00 and maxTime 18:00; done when the hour arrows can move from 09:00 to 08:00 and from 17:00 to 18:00.

Written by the indexing model from the issue text.

Description

example url: here
The example also has a similar issue as ours.

Our settings:
minTime: Date = new Date(2025, 4, 15, 8, 0);
maxTime: Date = new Date(2025, 4, 15, 18, 0);

minTime Issue:

  • Now if the hours is on 09 and minutes is on 00, the down arrow is disabled, though you should be able to go upto 08:00
  • Image
  • The only way to reduce is using the minutes and then reach 08:00

maxTime Issue:

  • Similarly if the hour is on 17 and minutes on 00, the up arrow to go to 18 is disabled.
  • The only way to reach 18:00 is through the clicking up arrow on minutes.
  • Image
Dominant language
TypeScript
Stars
5.5k
Forks
1.7k
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from valor-software/ngx-bootstrap

All issues in valor-software/ngx-bootstrap

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.