MasterDetailLayoutLocator can't press Esc on the detail or click the backdrop
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 25/100
Research direction
Start with the MasterDetailLayoutLocator and MasterDetailLayoutTester classes, which currently expose only getMaster(), getDetail(), getDetailPlaceholder() and isDetailPlaceholderVisible(). Read how the existing tester fires events and checks the detail mode, then look at the DetailEscapePressEvent and BackdropClickEvent usages in the issue. Done means pressEscapeOnDetail() and clickBackdrop() exist, fire client-originated events, and throw when the detail is not in overlay mode. Pull request #310 already targets this, so check it before starting.
Written by the indexing model from the issue text.
Description
Summary
When a MasterDetailLayout shows its detail on top of the master (the overlay mode on a narrow screen), the user can close it by pressing Esc or by clicking the backdrop. Applications listen for this with addDetailEscapePressListener(...) and addBackdropClickListener(...), for example to deselect the row or to ask about unsaved changes first.
MasterDetailLayoutLocator/MasterDetailLayoutTester can't simulate either. They only have getMaster(), getDetail(), getDetailPlaceholder() and isDetailPlaceholderVisible(). Tests have to fire the events themselves:
var layout = window.findMasterDetailLayout().component();
ComponentUtil.fireEvent(layout, new MasterDetailLayout.DetailEscapePressEvent(layout, true));
ComponentUtil.fireEvent(layout, new MasterDetailLayout.BackdropClickEvent(layout, true));
Expected
MasterDetailLayoutLocator gets methods like pressEscapeOnDetail() and clickBackdrop(). They fire the events as coming from the client, and refuse when the detail isn't shown in a mode where the user could do that.
Versions
Vaadin 25.3.4, browserless-test 25.3.2, Java 25.
- Dominant language
- Java
- Stars
- 1
- Forks
- 3
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 13
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from vaadin/browserless-test
-
Rename MultiSelectComboBoxTester.selectItem(String...) to selectItems(String...)Possibly taken @totally-not-ai claimed this 11 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
vaadin/browserless-test#291 · 3 comments ·
Maintainers usually reply within 1 day
-
(MultiSelect)ComboBoxTester add support for selectItemContaining(String)Possibly taken @totally-not-ai claimed this 32 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
vaadin/browserless-test#270 · 3 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
vaadin/browserless-test#266 · 2 comments ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
vaadin/browserless-test#123 ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 62/100
vaadin/browserless-test#305 · 1 comment ·
Maintainers usually reply within 1 day
All issues in vaadin/browserless-test
Similar issues
-
bug subsystem:agent-harness triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
ShaftHQ/SHAFT_ENGINE#7797 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
NationalSecurityAgency/ghidra#10155 ·
Maintainers usually reply within 2 days
-
bug web-ui
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
jenkinsci/jenkins#27705 · 3 comments ·
Maintainers usually reply within 1 day
-
mod bug
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
elmital/FixMCStats#65 · 3 comments ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
QuranHub/quranhub-android#354 ·
Maintainers usually reply within 2 days