Make AbstractBrowserlessExtension implement BrowserlessDsl
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 76/100
Research direction
Start with junit6/.../AbstractBrowserlessExtension.java and compare its duplicated DSL methods with the BrowserlessDsl contract, including the existing private getUI(). Update the extension so only currentUI() and runPendingSignalsTasks remain as DSL bodies, then run the BrowserlessExtension-based and per-class-lifecycle tests. Done means both test groups pass unchanged and the stated acceptance criteria are met.
Written by the indexing model from the issue text.
Description
Part of #120. Blocked by #121.
AbstractBrowserlessExtension (the @RegisterExtension programmatic API) is a third, verbatim copy of the DSL (navigate ×4, find ×2, findInView, getCurrentView, roundTrip, fireShortcut). Its private getUI() already implements exactly the currentUI() contract (returns UI.getCurrent(), throws BrowserlessTestSetupException if null).
Proposal
Declare AbstractBrowserlessExtension implements BrowserlessDsl, expose getUI() as public UI currentUI(), and delete the duplicated DSL method bodies. (Keep runPendingSignalsTasks until #125.) Low risk — identical public signatures.
Acceptance criteria
- The extension declares no DSL bodies beyond
currentUI()(and, for now,runPendingSignalsTasks). -
BrowserlessExtension-based and per-class-lifecycle tests pass unchanged.
Affected files
junit6/.../AbstractBrowserlessExtension.java.
- Dominant language
- Java
- Stars
- 1
- Forks
- 3
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 51
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from vaadin/browserless-test
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
vaadin/browserless-test#228 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 68/100
vaadin/browserless-test#226 · 2 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 45/100
vaadin/browserless-test#221 · 13 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
vaadin/browserless-test#201 · 4 comments ·
-
Add a CrudTester Open
Difficulty 5/5 Over a week Newbie friendliness 38/100
vaadin/browserless-test#195 ·
All issues in vaadin/browserless-test
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
infinispan/infinispan#18150 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
untriaged
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
opensearch-project/k-NN#3597 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100