fix: agentkit test hygiene — dead branch, misleading name, fragmented drift detectio
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 72/100
Research direction
Start with internal/agentkit/agentkit_test.go and read TestForgeGlobal_StructuralHardening, TestSkillFiles_DriftDetection, and TestForgeCoordinationSkill_StructuralHardening; run the relevant Go tests. Done means the TTL regression is detected, drift coverage and test naming match their scope, and a read failure does not prevent reporting other failures.
Written by the indexing model from the issue text.
Description
Follow-up from PR #59 review. Four non-blocking test quality findings in internal/agentkit/agentkit_test.go:
F1/F10 — Dead negative test in TestForgeGlobal_StructuralHardening
Assertion (6) checks for a line starting with "3." that also contains "ttl_seconds" and "auto-release". The current step 3 is "3. FINALLY, coordinator can emergency release..." which doesn't contain "ttl_seconds", so the branch can never fire. The regression it guards against (standalone TTL step reintroduced) would not be caught.
Suggested fix: match any line containing both "ttl_seconds" and "auto-release" that is NOT part of the comms_reserve call, regardless of step number.
F4 — TestSkillFiles_DriftDetection name implies generic scope
The name says "SkillFiles" but the implementation covers only always-on-guidance and forge-global (2 of 7 skills). Either scope the name (TestHardenedSkillFiles_DriftDetection) or extend to all 7 skills.
F2 — Fragmented drift detection
Drift detection is split across two tests covering disjoint subsets: TestSkillFiles_DriftDetection (2 skills) and TestForgeCoordinationSkill_StructuralHardening assertion (5) (1 skill). Four skills have no drift detection. Consider consolidating into a single parameterized test covering all 7.
F3 — t.Fatalf in loop masks failures
TestSkillFiles_DriftDetection uses t.Fatalf for ReadFile errors inside the skill loop. If both skills fail to read, only the first is reported. Use t.Errorf + continue instead.
- Dominant language
- Go
- Stars
- 0
- Forks
- 9
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 18
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from unbound-force/replicator
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
unbound-force/replicator#95 ·
Maintainers usually reply within 1 day
-
bug github_actions
Difficulty 2/5 Under an hour Newbie friendliness 80/100
unbound-force/replicator#89 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
unbound-force/replicator#85 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
unbound-force/replicator#77 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
unbound-force/replicator#63 ·
Maintainers usually reply within 1 day
All issues in unbound-force/replicator
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
unbound-force/gaze#353 ·
Maintainers usually reply within 1 day
-
bug cross-seed ready-for-human
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
OneBusAway/maglev#2102 ·
Maintainers usually reply within 2 days
-
affects-8.5 component/session severity/moderate sig/transaction type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
area: client enhancement priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
opensro-dev/opensro#3681 ·
Maintainers usually reply within 1 day