chore: unify findRepoRoot in agentkit_test.go before merging PRs #56 and #59

Open
#68 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Quiet
Tech stack
go
Domain
testing

Research direction

Read PRs #56 and #59 and inspect internal/agentkit/agentkit_test.go to compare their findRepoRoot definitions. Follow the stated merge order, then verify that #59 adopts the existing helper and both changes can merge without a compile error.

Written by the indexing model from the issue text.

Description

Problem

PRs #56 and #59 both define a findRepoRoot helper function in internal/agentkit/agentkit_test.go with incompatible signatures:

  • PR #56: func findRepoRoot(t *testing.T) string
  • PR #59: func findRepoRoot() (string, error)

Merging both will cause a compile error.

Resolution

Establish merge order: #56 merges first (introduces findRepoRoot(t *testing.T) string), then #59 rebases and adopts the existing function.

The (t *testing.T) string signature is preferred — it's idiomatic for test helpers (uses t.Helper() + t.Fatalf internally).

Context

Identified by review council run on 2026-08-10 across the DCP prompt hardening PR series (#54-#59).

Recommended merge order: #54 (merged) → #55 → #57 → #56 → #59

Dominant language
Go
Stars
0
Forks
9
Avg merge
1d 14h
Merged PRs (30d)
18

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from unbound-force/replicator

All issues in unbound-force/replicator

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.