chore: unify findRepoRoot in agentkit_test.go before merging PRs #56 and #59
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 35/100
Research direction
Read PRs #56 and #59 and inspect internal/agentkit/agentkit_test.go to compare their findRepoRoot definitions. Follow the stated merge order, then verify that #59 adopts the existing helper and both changes can merge without a compile error.
Written by the indexing model from the issue text.
Description
Problem
PRs #56 and #59 both define a findRepoRoot helper function in internal/agentkit/agentkit_test.go with incompatible signatures:
- PR #56:
func findRepoRoot(t *testing.T) string - PR #59:
func findRepoRoot() (string, error)
Merging both will cause a compile error.
Resolution
Establish merge order: #56 merges first (introduces findRepoRoot(t *testing.T) string), then #59 rebases and adopts the existing function.
The (t *testing.T) string signature is preferred — it's idiomatic for test helpers (uses t.Helper() + t.Fatalf internally).
Context
Identified by review council run on 2026-08-10 across the DCP prompt hardening PR series (#54-#59).
Recommended merge order: #54 (merged) → #55 → #57 → #56 → #59
- Dominant language
- Go
- Stars
- 0
- Forks
- 9
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 18
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from unbound-force/replicator
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
unbound-force/replicator#95 ·
Maintainers usually reply within 1 day
-
bug github_actions
Difficulty 2/5 Under an hour Newbie friendliness 80/100
unbound-force/replicator#89 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
unbound-force/replicator#85 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
unbound-force/replicator#77 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
unbound-force/replicator#63 ·
Maintainers usually reply within 1 day
All issues in unbound-force/replicator
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
unbound-force/gaze#353 ·
Maintainers usually reply within 1 day
-
bug cross-seed ready-for-human
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
OneBusAway/maglev#2102 ·
Maintainers usually reply within 2 days
-
affects-8.5 component/session severity/moderate sig/transaction type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
area: client enhancement priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
opensro-dev/opensro#3681 ·
Maintainers usually reply within 1 day