[BUG] AsyncTwilioHttpClient returns another request's response under concurrency
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 35/100
Research direction
Start with twilio/http/async_http_client.py and inspect AsyncTwilioHttpClient.request, especially how it stores and returns the response around session.close(). Run the concurrency example in the issue, then add or run a regression test that confirms each concurrent request returns its own response. Done means the test returns /first and /second for their matching requests; a pull request is already open for this fix.
Written by the indexing model from the issue text.
Description
Describe the bug
AsyncTwilioHttpClient.request stores the response in self._test_only_last_response and returns that attribute instead of a local variable. When the client has no pooled session (pool_connections=False), it awaits session.close() after the store. A second request that starts during that await resets the attribute to None and later overwrites it with its own response. The first request then returns None or the second request's response.
With None, Version.request fails with 'NoneType' object has no attribute 'status_code'. With the wrong response, the caller gets another request's body, for example the SID of a different message.
One client is the normal case: Client(...) builds one AsyncTwilioHttpClient and reuses it for every call. Any application that awaits two Twilio calls at the same time on one client can hit this. We hit it in production at about three messages.create_async calls per second.
The synchronous TwilioHttpClient has the same shape but never yields between the store and the return, so it is not affected.
Code snippet
No network needed. A fake stands in for ClientSession. It answers with the request path and yields to the event loop on close, as a real session does.
import asyncio
from unittest.mock import patch
from twilio.http.async_http_client import AsyncTwilioHttpClient
class FakeResponse:
def __init__(self, text):
self._text = text
self.status = 200
self.headers = {}
async def text(self):
return self._text
class FakeSession:
async def request(self, **kwargs):
return FakeResponse(kwargs["url"])
async def close(self):
await asyncio.sleep(0)
async def main():
with patch("twilio.http.async_http_client.ClientSession", FakeSession):
client = AsyncTwilioHttpClient(pool_connections=False)
responses = await asyncio.gather(
client.request("GET", "/first"), client.request("GET", "/second")
)
print([r.text if r is not None else None for r in responses])
asyncio.run(main())
With real credentials the same happens with two client.messages.create_async(...) calls in an asyncio.gather on a Client built with http_client=AsyncTwilioHttpClient(pool_connections=False).
Actual behavior
['/second', '/second']
The first request returns the second request's response. Depending on timing the first request returns None instead, and the SDK raises:
AttributeError: 'NoneType' object has no attribute 'status_code'
Expected behavior
['/first', '/second']
Each request returns its own response.
twilio-python version
9.4.6 in production. 9.12.0 and main carry the same code.
Python version
3.13.4
Logs or error messages
Failed to send SMS via Twilio: 'NoneType' object has no attribute 'status_code'
Additional context
The fix is to keep the response in a local variable and return it. The method can still set _test_only_last_response for the tests that read it. I have a pull request ready with the fix and a regression test.
- Dominant language
- Python
- Stars
- 2.1k
- Forks
- 821
- Avg merge
- 9h 33m
- Merged PRs (30d)
- 3
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from twilio/twilio-python
-
Docs: "Handling Exceptions" should mention that network errors are not `TwilioRestException`Possibly taken @henricop claimed this 13 days ago. Open
Difficulty 1/5 1-3 hours Newbie friendliness 90/100
twilio/twilio-python#986 · 1 comment ·
Maintainers usually reply within 1 day
-
Clearer diagnostic when an API Key SID is passed without `account_sid`Possibly taken @saryeljaramany claimed this 5 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
twilio/twilio-python#985 · 1 comment ·
Maintainers usually reply within 1 day
-
TokenPagination.next_page_async() makes a sync request and fails with an async http clientPossibly taken @sebxt claimed this 31 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
twilio/twilio-python#976 ·
Maintainers usually reply within 1 day
-
AsyncTwilioHttpClient does not JSON-serialize request bodies for application/json endpoints (sync client does) → 400 on JSON-body v2 endpointsPossibly taken @Steve0x2a claimed this 77 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
twilio/twilio-python#932 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
twilio/twilio-python#930 ·
Maintainers usually reply within 1 day
All issues in twilio/twilio-python
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 64/100
Maintainers usually reply within 1 day
-
area:cli area:security enhancement priority:medium size:small
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
RonaldHensbergen/composable-data-stack#1338 ·
Maintainers usually reply within 1 day
-
area:stdlib effort:S impact:med platform:linux type:bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
automated endpoint-dead needs-curation
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
almanac-data/climate-almanac#139 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
UKGovernmentBEIS/inspect_ai#6695 · 1 comment ·
Maintainers usually reply within 1 day