[BUG] AsyncTwilioHttpClient returns another request's response under concurrency

Aperta
#974 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@andret13pinto ci sta già lavorando.

Dal 19/10/2026.

  • #975 di @andret13pinto — aperta

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Ferma
Stack tecnologico
python
Ambito
api, backend

Direzione di ricerca

Start with twilio/http/async_http_client.py and inspect AsyncTwilioHttpClient.request, especially how it stores and returns the response around session.close(). Run the concurrency example in the issue, then add or run a regression test that confirms each concurrent request returns its own response. Done means the test returns /first and /second for their matching requests; a pull request is already open for this fix.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Describe the bug

AsyncTwilioHttpClient.request stores the response in self._test_only_last_response and returns that attribute instead of a local variable. When the client has no pooled session (pool_connections=False), it awaits session.close() after the store. A second request that starts during that await resets the attribute to None and later overwrites it with its own response. The first request then returns None or the second request's response.

With None, Version.request fails with 'NoneType' object has no attribute 'status_code'. With the wrong response, the caller gets another request's body, for example the SID of a different message.

One client is the normal case: Client(...) builds one AsyncTwilioHttpClient and reuses it for every call. Any application that awaits two Twilio calls at the same time on one client can hit this. We hit it in production at about three messages.create_async calls per second.

The synchronous TwilioHttpClient has the same shape but never yields between the store and the return, so it is not affected.

Code snippet

No network needed. A fake stands in for ClientSession. It answers with the request path and yields to the event loop on close, as a real session does.

import asyncio
from unittest.mock import patch

from twilio.http.async_http_client import AsyncTwilioHttpClient


class FakeResponse:
    def __init__(self, text):
        self._text = text
        self.status = 200
        self.headers = {}

    async def text(self):
        return self._text


class FakeSession:
    async def request(self, **kwargs):
        return FakeResponse(kwargs["url"])

    async def close(self):
        await asyncio.sleep(0)


async def main():
    with patch("twilio.http.async_http_client.ClientSession", FakeSession):
        client = AsyncTwilioHttpClient(pool_connections=False)
        responses = await asyncio.gather(
            client.request("GET", "/first"), client.request("GET", "/second")
        )
    print([r.text if r is not None else None for r in responses])


asyncio.run(main())

With real credentials the same happens with two client.messages.create_async(...) calls in an asyncio.gather on a Client built with http_client=AsyncTwilioHttpClient(pool_connections=False).

Actual behavior
['/second', '/second']

The first request returns the second request's response. Depending on timing the first request returns None instead, and the SDK raises:

AttributeError: 'NoneType' object has no attribute 'status_code'
Expected behavior
['/first', '/second']

Each request returns its own response.

twilio-python version

9.4.6 in production. 9.12.0 and main carry the same code.

Python version

3.13.4

Logs or error messages
Failed to send SMS via Twilio: 'NoneType' object has no attribute 'status_code'
Additional context

The fix is to keep the response in a local variable and return it. The method can still set _test_only_last_response for the tests that read it. I have a pull request ready with the fix and a regression test.

Lingua principale
Python
Stelle
2.1k
Fork
821
Merge medio
9h 33m
PR unite (30g)
3

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di twilio/twilio-python

Tutte le issue di twilio/twilio-python

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.