Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Decide whether a translated header falls back to the default language's menu

Open
  • Is something wrong?
#190 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Active
Tech stack
javascript
Domain
backend, documentation

Research direction

Read packages/render-engine/src/menuResolver.js and its tests to understand how resolveMenuSettings handles language folders and default-language fallback. Then compare the alternatives in docs-llms/core-menus.md and LANG-057, and inspect packages/editor-ui/src/pages/Menus.jsx for the delete dialog. Done means the chosen rule is implemented with tests and the documentation and dialog warning, if selected, match it.

Written by the indexing model from the issue text.

Description

question

When a language's menu is deleted, that language's pages show the main language's menu, unless the header's menu was picked by hand (then they show none). Decide: never fall back (proposed, plus a warning when deleting a menu a header uses), or keep the fallback and say so.

A header menu setting holds either a menu uuid (picked in the dropdown) or a slug (the theme default, e.g. main-menu, until someone picks). resolveMenuSettings (menuResolver.js ~185-200) resolves a slug in the rendering language's folder and, failing that, in the default language's — documented in core-menus.md. So deleting the Greek Main menu makes a Greek header still on the default show the English main menu (English labels, English targets), while a header whose Greek menu was picked shows no menu. The editor's dropdown then reads "Main menu (en)", but nothing else says so, and the Delete Menu dialog doesn't mention the header uses it. Seen in the 2026-10-18 #115 review (LANG-057). Options: (A) no slug fallback for non-default languages — a missing language menu shows no menu, as with a picked one; (B) keep the fallback and reword LANG-057, optionally warning in the delete dialog; (C) keep it but block or warn on deleting a menu a header uses. Proposed: A plus a "used by the Greek header" warning when deleting.

Done when: The chosen rule is implemented in menuResolver.js with tests, core-menus.md and LANG-057 describe it, and the delete dialog warning (if chosen) names where the menu is used.

Start: menuResolver.js, core-menus.md, Menus.jsx.

Dominant language
JavaScript
Stars
162
Forks
6
Avg merge
12h 55m
Merged PRs (30d)
2

Getting set up

  • Ships a Dockerfile or Docker Compose file
  • No pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from tsiger/widgetizer

All issues in tsiger/widgetizer

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.