@tscircuit/cli 0.1.2452 bundles brace-expansion 2.0.1 and minimatch 5.1.2 (via make-vfs), both with published advisories

Open
#5,767 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

  • #5768 by @cocvn157 — closed without merging
  • #5769 by @aswadi — closed without merging

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
48/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
bun, typescript

Research direction

Start with make-vfs's tsup build and its published dist/index.js, then check the dependency versions in bun.lock and how the CLI bundles make-vfs into dist/cli/main.js, dist/lib/index.js, and the worker files. Rebuild make-vfs with updated bundled dependencies, publish a compatible version, refresh the lockfile, and rebuild the CLI; verify the published bundles contain the fixed minimatch and brace-expansion code.

Written by the indexing model from the issue text.

Description

While scanning published npm packages for bundled third-party code we found that @tscircuit/[email protected] (npm latest) ships brace-expansion 2.0.1 and minimatch 5.1.2 in dist/cli/main.js, dist/lib/index.js, dist/cli/build/build.worker.js and dist/cli/snapshot/snapshot.worker.js. They are not declared dependencies, so npm audit and SCA tools cannot flag them.

Both arrive inside make-vfs: its published dist/index.js already inlines glob-promise → glob 8 → minimatch → brace-expansion. That holds for make-vfs 1.0.16 (the direct dependency in bun.lock) and 1.1.0 (pulled in by winterspec through @tscircuit/file-server), so refreshing bun.lock alone does not change these copies.

brace-expansion 2.0.1 and minimatch 5.1.2 are in the range of 11 published advisories (fixed in brace-expansion 2.1.7 and minimatch 5.1.8). We did not find an exploit path through the CLI: make-vfs only calls glob with the constant pattern **/* on the project directory, so no user-supplied pattern reaches minimatch or brace-expansion. Because the copies are invisible to dependency audits, we suggest updating them when convenient.

Advisories covering the bundled versions (11)

brace-expansion 2.0.1:

  • CVE-2025-5889 (GHSA-v6h2-p8h4-qcjw): regular expression denial of service (fixed 2.0.2)
  • CVE-2026-33750 (GHSA-f886-m6hf-6m8v): zero-step sequence causes process hang and memory exhaustion (fixed 2.0.3)
  • CVE-2026-13149 (GHSA-3jxr-9vmj-r5cp): exponential-time expansion of consecutive non-expanding {} groups (fixed 2.1.2)
  • CVE-2026-14257 (GHSA-mh99-v99m-4gvg): unbounded expansion length causing an out-of-memory crash (fixed 2.1.3)
  • CVE-2026-69152 (GHSA-rgw5-rvv9-x895): unbounded intermediate arrays, bypassing the CVE-2026-14257 mitigation (fixed 2.1.4)
  • CVE-2026-102276 (GHSA-6j4f-fj2g-mc7p): uncontrolled recursion in parseCommaParts (fixed 2.1.5)
  • CVE-2026-102278 (GHSA-qhr7-859c-m2p7): uncontrolled recursion on nested brace groups (fixed 2.1.6)
  • CVE-2026-102277 (GHSA-q2hr-2g5m-vwhr): quadratic-time expansion of the {a},b} rewrite (fixed 2.1.7)

minimatch 5.1.2:

  • CVE-2026-26996 (GHSA-3ppc-4f35-3m26): ReDoS via repeated wildcards with a non-matching literal (fixed 5.1.7)
  • CVE-2026-27903 (GHSA-7r86-cg39-jmmj): ReDoS from matchOne() backtracking over multiple non-adjacent GLOBSTAR segments (fixed 5.1.8)
  • CVE-2026-27904 (GHSA-23c5-xmqv-rm74): ReDoS from nested *() extglobs (fixed 5.1.8)

Reproduce (published tarballs, 2026-11-11):

npm pack --silent @tscircuit/[email protected] [email protected] [email protected] [email protected]
mkdir c v m b
tar xzf tscircuit-cli-0.1.2452.tgz -C c; tar xzf make-vfs-1.0.16.tgz -C v
tar xzf minimatch-5.1.9.tgz -C m; tar xzf brace-expansion-2.1.7.tgz -C b
grep -c 'node_modules/make-vfs/dist/index.js' c/package/dist/cli/main.js c/package/dist/lib/index.js c/package/dist/cli/*/*.worker.js
grep -c '_matchGlobstar' c/package/dist/cli/main.js c/package/dist/lib/index.js c/package/dist/cli/*/*.worker.js v/package/dist/index.js m/package/minimatch.js   # added in minimatch 5.1.8
grep -c 'EXPANSION_MAX_DEPTH' c/package/dist/cli/main.js c/package/dist/lib/index.js c/package/dist/cli/*/*.worker.js v/package/dist/index.js b/package/index.js   # added in brace-expansion 2.1.6
tscircuit-cli-0.1.2452.tgz
make-vfs-1.0.16.tgz
minimatch-5.1.9.tgz
brace-expansion-2.1.7.tgz
c/package/dist/cli/main.js:2
c/package/dist/lib/index.js:1
c/package/dist/cli/build/build.worker.js:1
c/package/dist/cli/snapshot/snapshot.worker.js:1
c/package/dist/cli/main.js:0
c/package/dist/lib/index.js:0
c/package/dist/cli/build/build.worker.js:0
c/package/dist/cli/snapshot/snapshot.worker.js:0
v/package/dist/index.js:0
m/package/minimatch.js:2
c/package/dist/cli/main.js:0
c/package/dist/lib/index.js:0
c/package/dist/cli/build/build.worker.js:0
c/package/dist/cli/snapshot/snapshot.worker.js:0
v/package/dist/index.js:0
b/package/index.js:3

Suggested fix: make-vfs's tsup build inlines glob from its devDependencies, so the update starts there: rebuild it with a fresh lockfile (glob 8's minimatch ^5.0.1 now resolves 5.1.9, which pulls brace-expansion 2.1.7) and publish it as 1.1.1 or later, so that both make-vfs ^1.0.15 here and winterspec's ^1.1.0 accept it; then refresh bun.lock and rebuild the CLI.

Dominant language
TypeScript
Stars
19
Forks
115
Avg merge
1h 50m
Merged PRs (30d)
260

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from tscircuit/cli

All issues in tscircuit/cli

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.