Comments CTA has no gap between "Already a member?" and "Sign in" in right-to-left locales
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 92/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- react, tailwindcss, typescript
- Domain
- frontend
Research direction
Open apps/comments-ui/src/components/content/cta-box.tsx and look at line 71, where the "Already a member?" span uses the physical mr-1 class. Replace it with the logical inline-end margin me-1, which Tailwind 3.4 supports, so the gap follows the writing direction. To verify, run comments-ui with an RTL locale such as ar and confirm a gap appears in the rendered comments frame; check an LTR locale still looks unchanged.
Written by the indexing model from the issue text.
Description
Issue Summary
In a right-to-left locale (seen with ar), the comments call-to-action box renders "Already a member?" and the "Sign in" button with no space between them. The text runs together, e.g. «هل انت مسجل بالفعل؟تسجيل الدخول».
The cause is in apps/comments-ui/src/components/content/cta-box.tsx, line 71:
<span className="mr-1 inline-block text-[15px]">{t('Already a member?')}</span>
mr-1 is a physical right margin. In left-to-right layout it sits between the span and the button. In right-to-left layout the button is on the span's left, so the 4px margin lands on the outer side and the gap is 0.
Measured in the rendered comments frame (dir="rtl"): the span has margin-right 4px and margin-left 0px, and its left edge touches the button's right edge (gap 0px).
A likely fix is the logical margin me-1 (margin-inline-end), which Tailwind 3.3+ supports. comments-ui uses Tailwind 3.4. I have not built or tested that change.
Steps to Reproduce
- Set the site's publication language to ar (or any right-to-left locale) and enable comments for all members.
- Open any post while signed out.
- Look at the line under the "Sign up now" button in the comments box.
- Expected: a space between «هل أنت مسجل بالفعل؟» and «تسجيل الدخول», as in left-to-right locales. Actual: no space; the two run together.
Ghost Version
Current main (cta-box.tsx unchanged at e98ceb9); seen live with comments-ui 1.6 from the CDN.
Node.js Version
Not relevant (frontend; comments-ui is loaded from the CDN)
How did you install Ghost?
Self-hosted, Docker
Database type
MySQL 8
Browser & OS version
Chromium-based browser on Linux.
Relevant log / error output
Code of Conduct
- I agree to be friendly and polite to people in this repository
- Dominant language
- TypeScript
- Stars
- 55.8k
- Forks
- 12.1k
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 617
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from TryGhost/Ghost
-
needs:triage
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
needs:triage
Difficulty 2/5 1-3 hours Newbie friendliness 63/100
Maintainers usually reply within 1 day
-
needs:triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
HTML import of product cards mistakes description links for the product buttonPossibly taken @JoaoMarcos44 claimed this 14 days ago. Openaffects:api affects:editor affects:import/upgrade bug
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
TryGhost/Ghost#32429 · 2 comments ·
Maintainers usually reply within 1 day
-
[a11y] Portal toggles for email preferences don't have accessible labelsMay be free again A pull request for this issue was closed without being merged. Openaffects:a11y
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
TryGhost/Ghost#29667 · 1 comment ·
Maintainers usually reply within 1 day
Similar issues
-
area:cli area:security bug priority:medium
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
"code source" and "numerique.gouv" links: "new window" mention duplicated in the accessible nameOpenaccessibility
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
numerique-gouv/lasuite-landingpage#315 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
HyeokjaeChoi/vaultme#585 ·
Maintainers usually reply within 1 day
-
enhancement priority/P2
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
beettlle/pi-smart-router#200 ·
-
Folder workspaces disappear from sidebar in manual groups without a base folderPossibly taken @bbingz claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
stablyai/orca#42865 · 1 comment ·
Maintainers usually reply within 1 day