🐛 Bug Report: MCP uninstrument() keeps tracing and reinstrumentation duplicates spans

Open
#4,653 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

@harshb16 is already working on this.

Since Oct 22, 2026.

  • #4654 by @harshb16 — open

Assessment

Difficulty
3/5
Estimated time
Half a day
Newbie friendliness
76/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
python

Research direction

Start in packages/opentelemetry-instrumentation-mcp, reading the MCP instrumentor lifecycle, FastMCPInstrumentor.uninstrument(), and the fixture in tests/conftest.py. Run the supplied reproducer to confirm enabled → disabled → re-enabled span counts. Add a regression test covering completed sessions and ensure uninstrument removes all wrappers, while re-instrumenting produces the original span count without duplication.

Written by the indexing model from the issue text.

Description

Which component is this bug for?

All Packages (MCP is missing from the dropdown). Affected package: opentelemetry-instrumentation-mcp.

📜 Description

After McpInstrumentor().uninstrument(), completed MCP calls continue exporting spans even though is_instrumented_by_opentelemetry is False. Re-enabling instrumentation adds another tracing layer.

Reproduced against source commit 8d9c93f, using an in-memory FastMCP server. Each tool call executes once and returns the correct result. No cancellation or active-session teardown is needed.

👟 Reproduction steps
  1. Instrument MCP, open a client session, call a tool, and close the session.
  2. Uninstrument and repeat the call in another completed session.
  3. Re-instrument and repeat again, inspecting exported spans after each step.
Tested reproducer and environment setup

From the repository root at the commit above, create an environment:

python3.11 -m venv /tmp/openllmetry-mcp-repro
/tmp/openllmetry-mcp-repro/bin/python -m pip install \
  fastmcp==2.14.3 mcp==1.26.0 wrapt==1.17.3 \
  opentelemetry-sdk==1.42.1 opentelemetry-instrumentation==0.63b1

Save this as /tmp/repro_mcp_uninstrument.py:

import asyncio

from fastmcp import Client, FastMCP
from opentelemetry.instrumentation.mcp import McpInstrumentor
from opentelemetry.sdk.trace import TracerProvider
from opentelemetry.sdk.trace.export import SimpleSpanProcessor
from opentelemetry.sdk.trace.export.in_memory_span_exporter import InMemorySpanExporter


async def main():
    exporter = InMemorySpanExporter()
    provider = TracerProvider()
    provider.add_span_processor(SimpleSpanProcessor(exporter))
    instrumentor = McpInstrumentor()
    instrumentor.instrument(tracer_provider=provider)
    server = FastMCP("lifecycle-repro")
    executions = 0

    @server.tool()
    async def add_numbers(a: int, b: int) -> int:
        nonlocal executions
        executions += 1
        return a + b

    client = Client(server)
    observations = {}
    try:
        for phase in ("enabled", "disabled", "re-enabled"):
            if phase == "disabled":
                instrumentor.uninstrument()
            elif phase == "re-enabled":
                instrumentor.instrument(tracer_provider=provider)
            exporter.clear()
            before = executions
            async with client:
                result = await client.call_tool("add_numbers", {"a": 5, "b": 3})
                assert result.content[0].text == "8"
            spans = exporter.get_finished_spans()
            counts = (len(spans), sum(s.name == "add_numbers.tool" for s in spans))
            observations[phase] = counts
            assert executions - before == 1
            print(f"{phase}: enabled={instrumentor.is_instrumented_by_opentelemetry}, "
                  f"spans={counts[0]}, tool_spans={counts[1]}", flush=True)
    finally:
        instrumentor.uninstrument()
        provider.shutdown()

    assert observations["disabled"] == (0, 0), observations
    assert observations["re-enabled"] == observations["enabled"], observations


asyncio.run(main())

Run against the unchanged source:

PYTHONDONTWRITEBYTECODE=1 \
PYTHONPATH="$PWD/packages/opentelemetry-instrumentation-mcp:$PWD/packages/opentelemetry-semantic-conventions-ai" \
/tmp/openllmetry-mcp-repro/bin/python /tmp/repro_mcp_uninstrument.py

This imports the instrumentation and project semantic conventions from the checkout, not the released wheel. The dependencies satisfy the source manifests; the older lockfile was not regenerated or used for this environment.

👍 Expected behavior

Disabled calls export no MCP spans. Re-enabling restores the original tracing behavior without multiplying spans or changing application behavior.

👎 Actual Behavior with Screenshots
Phase Reports enabled Total spans Tool spans
Enabled True 6 2
Disabled False 6 2
Re-enabled True 11 4

The script fails its disabled-span assertion. The two initial tool spans are legitimate client/server spans; the re-enabled call duplicates them. Another cycle produces 16 total spans and six tool spans.

🤖 Python Version

3.11.15, macOS on Apple Silicon. Dependency versions are in the setup above.

📃 Provide any additional context for the Bug.

_uninstrument() currently unwraps only the stdio transports; FastMCPInstrumentor.uninstrument() is a no-op. The test fixture acknowledges wrapper stacking and avoids it through session-scoped instrumentation. The author of #4103 explicitly deferred the deeper fix.

Controls produced zero spans without instrumentation and stable counts without toggling. Fresh clients reproduced the failure. The existing in-memory client/session tests still pass (24 tests).

@doronkopit5, may I take this on and submit a focused fix with regression tests? Is anyone already working on it? My initial scope would be the completed-session enable → disable → re-enable sequence above.

👀 Have you spent some time to check if this bug has been raised before?
  • I checked and didn't find similar issue

This is a previously acknowledged bug. I found no dedicated MCP uninstrumentation issue or implementation in the public issues, PRs, and related discussions I checked. Please point me to existing work if I missed it.

Are you willing to submit PR?

Yes I am willing to submit a PR!

Dominant language
Python
Stars
7.5k
Forks
1.2k
Avg merge
2d 6h
Merged PRs (30d)
2

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from traceloop/openllmetry

All issues in traceloop/openllmetry

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.