🐛 Bug Report: MCP uninstrument() keeps tracing and reinstrumentation duplicates spans

Abierto
#4,653 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@harshb16 ya está trabajando en esto.

Desde el 22/10/2026.

  • #4654 de @harshb16 — abierto

Evaluación

Dificultad
3/5
Tiempo estimado
Medio día
Aptitud para principiantes
76/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
python

Línea de trabajo

Start in packages/opentelemetry-instrumentation-mcp, reading the MCP instrumentor lifecycle, FastMCPInstrumentor.uninstrument(), and the fixture in tests/conftest.py. Run the supplied reproducer to confirm enabled → disabled → re-enabled span counts. Add a regression test covering completed sessions and ensure uninstrument removes all wrappers, while re-instrumenting produces the original span count without duplication.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Which component is this bug for?

All Packages (MCP is missing from the dropdown). Affected package: opentelemetry-instrumentation-mcp.

📜 Description

After McpInstrumentor().uninstrument(), completed MCP calls continue exporting spans even though is_instrumented_by_opentelemetry is False. Re-enabling instrumentation adds another tracing layer.

Reproduced against source commit 8d9c93f, using an in-memory FastMCP server. Each tool call executes once and returns the correct result. No cancellation or active-session teardown is needed.

👟 Reproduction steps
  1. Instrument MCP, open a client session, call a tool, and close the session.
  2. Uninstrument and repeat the call in another completed session.
  3. Re-instrument and repeat again, inspecting exported spans after each step.
Tested reproducer and environment setup

From the repository root at the commit above, create an environment:

python3.11 -m venv /tmp/openllmetry-mcp-repro
/tmp/openllmetry-mcp-repro/bin/python -m pip install \
  fastmcp==2.14.3 mcp==1.26.0 wrapt==1.17.3 \
  opentelemetry-sdk==1.42.1 opentelemetry-instrumentation==0.63b1

Save this as /tmp/repro_mcp_uninstrument.py:

import asyncio

from fastmcp import Client, FastMCP
from opentelemetry.instrumentation.mcp import McpInstrumentor
from opentelemetry.sdk.trace import TracerProvider
from opentelemetry.sdk.trace.export import SimpleSpanProcessor
from opentelemetry.sdk.trace.export.in_memory_span_exporter import InMemorySpanExporter


async def main():
    exporter = InMemorySpanExporter()
    provider = TracerProvider()
    provider.add_span_processor(SimpleSpanProcessor(exporter))
    instrumentor = McpInstrumentor()
    instrumentor.instrument(tracer_provider=provider)
    server = FastMCP("lifecycle-repro")
    executions = 0

    @server.tool()
    async def add_numbers(a: int, b: int) -> int:
        nonlocal executions
        executions += 1
        return a + b

    client = Client(server)
    observations = {}
    try:
        for phase in ("enabled", "disabled", "re-enabled"):
            if phase == "disabled":
                instrumentor.uninstrument()
            elif phase == "re-enabled":
                instrumentor.instrument(tracer_provider=provider)
            exporter.clear()
            before = executions
            async with client:
                result = await client.call_tool("add_numbers", {"a": 5, "b": 3})
                assert result.content[0].text == "8"
            spans = exporter.get_finished_spans()
            counts = (len(spans), sum(s.name == "add_numbers.tool" for s in spans))
            observations[phase] = counts
            assert executions - before == 1
            print(f"{phase}: enabled={instrumentor.is_instrumented_by_opentelemetry}, "
                  f"spans={counts[0]}, tool_spans={counts[1]}", flush=True)
    finally:
        instrumentor.uninstrument()
        provider.shutdown()

    assert observations["disabled"] == (0, 0), observations
    assert observations["re-enabled"] == observations["enabled"], observations


asyncio.run(main())

Run against the unchanged source:

PYTHONDONTWRITEBYTECODE=1 \
PYTHONPATH="$PWD/packages/opentelemetry-instrumentation-mcp:$PWD/packages/opentelemetry-semantic-conventions-ai" \
/tmp/openllmetry-mcp-repro/bin/python /tmp/repro_mcp_uninstrument.py

This imports the instrumentation and project semantic conventions from the checkout, not the released wheel. The dependencies satisfy the source manifests; the older lockfile was not regenerated or used for this environment.

👍 Expected behavior

Disabled calls export no MCP spans. Re-enabling restores the original tracing behavior without multiplying spans or changing application behavior.

👎 Actual Behavior with Screenshots
Phase Reports enabled Total spans Tool spans
Enabled True 6 2
Disabled False 6 2
Re-enabled True 11 4

The script fails its disabled-span assertion. The two initial tool spans are legitimate client/server spans; the re-enabled call duplicates them. Another cycle produces 16 total spans and six tool spans.

🤖 Python Version

3.11.15, macOS on Apple Silicon. Dependency versions are in the setup above.

📃 Provide any additional context for the Bug.

_uninstrument() currently unwraps only the stdio transports; FastMCPInstrumentor.uninstrument() is a no-op. The test fixture acknowledges wrapper stacking and avoids it through session-scoped instrumentation. The author of #4103 explicitly deferred the deeper fix.

Controls produced zero spans without instrumentation and stable counts without toggling. Fresh clients reproduced the failure. The existing in-memory client/session tests still pass (24 tests).

@doronkopit5, may I take this on and submit a focused fix with regression tests? Is anyone already working on it? My initial scope would be the completed-session enable → disable → re-enable sequence above.

👀 Have you spent some time to check if this bug has been raised before?
  • I checked and didn't find similar issue

This is a previously acknowledged bug. I found no dedicated MCP uninstrumentation issue or implementation in the public issues, PRs, and related discussions I checked. Please point me to existing work if I missed it.

Are you willing to submit PR?

Yes I am willing to submit a PR!

Lenguaje dominante
Python
Estrellas
7.5k
Forks
1.2k
Merge medio
1 d 23 h
PR fusionados (30 d)
3

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de traceloop/openllmetry

Todos los issues de traceloop/openllmetry

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.