[Bug]: Subsonic POST stream/download ignores credentials in the form body
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 65/100
Research direction
Start at src/api/subsonic/mod.rs:324, where stream/download hand the raw request straight to the file response without reading the body. Read how the other endpoints parse the form body and validate u/p/t/s/id, then see what the file response builder actually needs from the request (method and Range header) so it can be constructed from those parts. Done when the curl command in the issue authenticates and returns audio, and the existing subsonic tests still pass.
Written by the indexing model from the issue text.
Description
[!NOTE]
This issue was written by Claude (Claude Opus 5.5) from a code review session with @PhrolovaMoe. It was found by reading the code and hasn't been reproduced on a running server.
Version
0.40.0 (feat/desktop, 017a837b)
Area
Other
What happened?
For stream and download, rest never reads the request body so it can hand the request to the file response (src/api/subsonic/mod.rs:324). A client using the advertised formPost extension sends u, p/t/s and id in the body, so those requests fail with "required parameter is missing: u".
Steps to reproduce
curl -X POST -H 'Content-Type: application/x-www-form-urlencoded' -d 'u=me&p=…&c=test&id=…' http://host/rest/stream
Expected behavior
POST stream/download authenticate and play like every other endpoint.
Suggested fix
Read and parse the form body for these too, then build the file response from the remaining request parts (method and Range headers) instead of the original Request.
- Dominant language
- TypeScript
- Stars
- 4
- Forks
- 1
- Avg merge
- 4h 49m
- Merged PRs (30d)
- 5
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from tinystream-dev/tinystream
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
tinystream-dev/tinystream#132 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
tinystream-dev/tinystream#131 ·
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 88/100
tinystream-dev/tinystream#129 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
tinystream-dev/tinystream#128 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
tinystream-dev/tinystream#124 ·
All issues in tinystream-dev/tinystream
Similar issues
-
Console writes URL credentials to the local log, though AGENTS.md says secrets never reach diskOpen
Difficulty 1/5 Under an hour Newbie friendliness 86/100
sandbox-quantum/switch#2163 ·
Maintainers usually reply within 1 day
-
automated issue report
Difficulty 1/5 Under an hour Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
area/dashboard kind/bug QA/dev-automation
Difficulty 1/5 Under an hour Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
bug pydanty:is-working
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
pydantic/pydantic-ai#13939 ·
Maintainers usually reply within 1 day
-
self-host
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
funmusicplace/mirlo#2625 ·
Maintainers usually reply within 1 day