[Bug]: Subsonic POST stream/download ignores credentials in the form body

未關閉
#111 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

評估

難度
3/5
預估耗時
1-2 天
新手友好度
65/100
Issue 類型
缺陷
描述清晰度
描述清楚
活躍度
活躍
技術堆疊
rust
領域
api, backend

研究方向

Start at src/api/subsonic/mod.rs:324, where stream/download hand the raw request straight to the file response without reading the body. Read how the other endpoints parse the form body and validate u/p/t/s/id, then see what the file response builder actually needs from the request (method and Range header) so it can be constructed from those parts. Done when the curl command in the issue authenticates and returns audio, and the existing subsonic tests still pass.

由索引模型根據 Issue 內容生成。

描述

bug

[!NOTE]
This issue was written by Claude (Claude Opus 5.5) from a code review session with @PhrolovaMoe. It was found by reading the code and hasn't been reproduced on a running server.

Version

0.40.0 (feat/desktop, 017a837b)

Area

Other

What happened?

For stream and download, rest never reads the request body so it can hand the request to the file response (src/api/subsonic/mod.rs:324). A client using the advertised formPost extension sends u, p/t/s and id in the body, so those requests fail with "required parameter is missing: u".

Steps to reproduce

curl -X POST -H 'Content-Type: application/x-www-form-urlencoded' -d 'u=me&p=…&c=test&id=…' http://host/rest/stream

Expected behavior

POST stream/download authenticate and play like every other endpoint.

Suggested fix

Read and parse the form body for these too, then build the file response from the remaining request parts (method and Range headers) instead of the original Request.

主要語言
TypeScript
星號
4
分支
1
平均合併
4 小時 49 分鐘
30 天內合併 PR
5

環境準備

  • 提供 Dockerfile 或 Docker Compose 檔案
  • 沒有 Pull Request 範本
  • 沒有貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

tinystream-dev/tinystream 的其他 Issue

查看 tinystream-dev/tinystream 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。