[Bug]: Book resources and video font attachments are served as active content (stored XSS)
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 52/100
Research direction
Start at the two named sinks, src/books/mod.rs:144 and src/api/media.rs:188, and read whatever helper guesses the MIME type from the zip or MKV attachment name. Then read the middleware stack in src/api/mod.rs to see where COOP/COEP is added, since that is where a global X-Content-Type-Options: nosniff belongs. Done means SVG/HTML/XHTML from books or fonts come back as application/octet-stream with Content-Disposition: attachment and a sandboxing CSP on those routes, verified by a test asserting the response headers on a crafted EPUB entry.
Written by the indexing model from the issue text.
Description
[!NOTE]
This issue was written by Claude (Claude Opus 5.5) from a code review session with @PhrolovaMoe. It was found by reading the code and hasn't been reproduced on a running server.
Version
0.40.0 (feat/desktop, 017a837b)
Area
Other
What happened?
/api/books/{id}/files/{*name} serves files from inside an EPUB with a MIME type guessed from the name in the zip (src/books/mod.rs:144). /api/media/{id}/fonts/{index} does the same with MKV attachment file names (src/api/media.rs:188). An .svg, .xhtml or .html inside a downloaded book or torrented MKV is served as image/svg+xml / text/html on the app's own origin, where scripts can use the signed-in user's session. No response sets X-Content-Type-Options: nosniff or a CSP; the global middleware only adds COOP/COEP (src/api/mod.rs).
Steps to reproduce
- Put an EPUB with
OEBPS/x.svgcontaining<svg xmlns="http://www.w3.org/2000/svg" onload="alert(document.domain)"/>in a books library. - Open
/api/books/<id>/files/OEBPS/x.svgwhile signed in.
Expected behavior
Files from books and media attachments never run script on the app's origin.
Suggested fix
- Serve fonts with a font MIME type or
application/octet-stream, never one guessed from an arbitrary name. - For book resources, allow only image/font/CSS types the reader needs, and send everything else as
application/octet-streamwithContent-Disposition: attachment. - Add
X-Content-Type-Options: nosniffglobally andContent-Security-Policy: sandbox(ordefault-src 'none') on these file routes.
- Dominant language
- TypeScript
- Stars
- 4
- Forks
- 1
- Avg merge
- 4h 49m
- Merged PRs (30d)
- 5
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from tinystream-dev/tinystream
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
tinystream-dev/tinystream#132 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
tinystream-dev/tinystream#131 ·
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 88/100
tinystream-dev/tinystream#129 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
tinystream-dev/tinystream#128 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
tinystream-dev/tinystream#124 ·
All issues in tinystream-dev/tinystream
Similar issues
-
Console writes URL credentials to the local log, though AGENTS.md says secrets never reach diskOpen
Difficulty 1/5 Under an hour Newbie friendliness 86/100
sandbox-quantum/switch#2163 ·
Maintainers usually reply within 1 day
-
automated issue report
Difficulty 1/5 Under an hour Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
area/dashboard kind/bug QA/dev-automation
Difficulty 1/5 Under an hour Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
bug pydanty:is-working
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
pydantic/pydantic-ai#13939 ·
Maintainers usually reply within 1 day
-
self-host
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
funmusicplace/mirlo#2625 ·
Maintainers usually reply within 1 day