[Bug]: Book resources and video font attachments are served as active content (stored XSS)

Aberta
#103 0 comentários 0 reações 0 responsáveis Ver no GitHub

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
52/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
rust
Domínio
backend, security

Direção de pesquisa

Start at the two named sinks, src/books/mod.rs:144 and src/api/media.rs:188, and read whatever helper guesses the MIME type from the zip or MKV attachment name. Then read the middleware stack in src/api/mod.rs to see where COOP/COEP is added, since that is where a global X-Content-Type-Options: nosniff belongs. Done means SVG/HTML/XHTML from books or fonts come back as application/octet-stream with Content-Disposition: attachment and a sandboxing CSP on those routes, verified by a test asserting the response headers on a crafted EPUB entry.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

bug

[!NOTE]
This issue was written by Claude (Claude Opus 5.5) from a code review session with @PhrolovaMoe. It was found by reading the code and hasn't been reproduced on a running server.

Version

0.40.0 (feat/desktop, 017a837b)

Area

Other

What happened?

/api/books/{id}/files/{*name} serves files from inside an EPUB with a MIME type guessed from the name in the zip (src/books/mod.rs:144). /api/media/{id}/fonts/{index} does the same with MKV attachment file names (src/api/media.rs:188). An .svg, .xhtml or .html inside a downloaded book or torrented MKV is served as image/svg+xml / text/html on the app's own origin, where scripts can use the signed-in user's session. No response sets X-Content-Type-Options: nosniff or a CSP; the global middleware only adds COOP/COEP (src/api/mod.rs).

Steps to reproduce
  1. Put an EPUB with OEBPS/x.svg containing <svg xmlns="http://www.w3.org/2000/svg" onload="alert(document.domain)"/> in a books library.
  2. Open /api/books/<id>/files/OEBPS/x.svg while signed in.
Expected behavior

Files from books and media attachments never run script on the app's origin.

Suggested fix
  • Serve fonts with a font MIME type or application/octet-stream, never one guessed from an arbitrary name.
  • For book resources, allow only image/font/CSS types the reader needs, and send everything else as application/octet-stream with Content-Disposition: attachment.
  • Add X-Content-Type-Options: nosniff globally and Content-Security-Policy: sandbox (or default-src 'none') on these file routes.
Linguagem predominante
TypeScript
Estrelas
4
Forks
1
Merge médio
4h 49min
PRs com merge (30d)
5

Preparar o ambiente

  • Inclui um Dockerfile ou arquivo Docker Compose
  • Sem modelo de pull request
  • Sem guia de contribuição

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de tinystream-dev/tinystream

Todas as issues de tinystream-dev/tinystream

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.