local: play history of duplicate songs merged by remapPaths may be orphaned
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Start in SongDataDao.remapPaths, in the duplicateIds branch, and read how playlist entries and favourites are moved to the surviving song. Then search for any existing code that deletes duplicate songs and check whether it already repoints play_events and resume_points. If it does not, the fix moves those rows from each duplicate's path to the survivor's path in the same transaction. Done means a test beside SongPathRemapHistoryTest shows that history survives deletion of the duplicate rows.
Written by the indexing model from the issue text.
Description
Found in review of the #1023 fix (unconfirmed).
SongDataDao.remapPaths, duplicateIds branch: when a remap finds duplicate song rows, it moves their playlist entries and favourites onto the surviving song, but not the play_events or resume points keyed by the duplicates' own paths. If the duplicate rows are later deleted, that history is orphaned (same join as #1023: songs.path = e.songPath AND mediaProvider).
To check: whether duplicate deletion elsewhere already repoints history; if not, move play_events.songPath / resume_points.songPath from each duplicate's path to the survivor's path in the same transaction, with a test next to SongPathRemapHistoryTest.
- Dominant language
- Kotlin
- Stars
- 231
- Forks
- 28
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from timusus/Shuttle2
-
support/scripts/asc: S2 bundle id resolves to the Podcasts app (bundleId filter is a prefix match)Openbug next-release
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
bug design impact:U1 later P3 reach:R2 size:S
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
enhancement impact:U1 later P3 reach:R2 size:S
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
impact:U1 owner reach:R1 size:S
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
idea
Difficulty 5/5 Over a week Newbie friendliness 25/100
All issues in timusus/Shuttle2
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
Maintainers usually reply within 1 day
-
afk-ok area:agents size:S
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
enorm-labs/event-junkie#3523 ·
Maintainers usually reply within 1 day
-
submit-adaption submit-adaption-pre
Difficulty 1/5 Under an hour Newbie friendliness 82/100
BetterAndroid/android-notification-icon-project#750 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
lysine-dev/okhttp#9797 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
openbase/planetsudo.engine#107 ·
Maintainers usually reply within 1 day