Skip result deserialization for local activities and SideEffect when not replaying (mutableSideEffect already does this)
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 54/100
Research direction
Start by reading SyncWorkflowContext.mutableSideEffectImpl, which the issue identifies as the existing pattern, then trace how SideEffect and Local Activities serialize and deserialize results. Check the relevant tests for replay and non-replay behavior; done means non-replaying execution returns the original result while replay still deserializes it.
Written by the indexing model from the issue text.
Description
MutableSideEffect already avoids deserializing a result it just serialized as it keeps the original object and only deserializes when the workflow is replaying (SyncWorkflowContext.mutableSideEffectImpl)
Currently SideEffect and Local Activities dont do this - both serialize the result and immediately deserialize it again, even tho the original object is in same process.
Why it matters:
For cases where local activities can return larger results and/or run large num of local activities, the repeated deserialization can cost cpu.
Ask:
when workflow execution is not replaying, return the original object to SideEffect and Local Activity result similarly what MutableSideEffect does.
- Dominant language
- Java
- Stars
- 434
- Forks
- 260
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 19
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from temporalio/sdk-java
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
temporalio/sdk-java#3134 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
temporalio/sdk-java#1825 ·
Maintainers usually reply within 1 day
-
Proposal: handle SIGTERM by default to initiate graceful worker shutdownPossibly taken @eamsden claimed this 3 days ago. Open
temporalio/sdk-java#3135 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 3/5 1-2 days Newbie friendliness 55/100
temporalio/sdk-java#3124 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 35/100
temporalio/sdk-java#3122 ·
Maintainers usually reply within 1 day
All issues in temporalio/sdk-java
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
lugassawan/swe-workbench#799 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Vakore/ZappierGames#89 ·
-
1.20.1-FORGE Module-Enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
MehVahdJukaar/WoodGood#1340 · 1 comment ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
PssbleTrngle/dye_depot#123 ·
-
bug question
Difficulty 2/5 1-3 hours Newbie friendliness 67/100