Support the certificate with linebreak strings from env variable
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 65/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- java, spring-boot
- Domain
- backend
Research direction
Start in temporal-spring-boot-autoconfigure-alpha/src/main/java/io/temporal/spring/boot/autoconfigure/template/ServiceStubOptionsTemplate.java at the certificate validation line referenced in the issue, and trace how certificate and key values reach it from ServiceStubsAutoConfiguration. Done means certificate and private-key values containing escaped "\n" from environment variables are accepted after conversion to line breaks, while existing application.yaml/properties behavior remains supported.
Written by the indexing model from the issue text.
Description
Is your feature request related to a problem? Please describe.
We store the temporal cloud cert and private key as env vars opposed to application.yaml/prop.
Because the env var values cannot contain linebreak/linefeed special characters, the ServiceStubOptionsTemaplte fails to load cert/key saying it is not valid cert on this line .
(It works perfectly with application.yaml/propeties because it converts "\n" to linebreak)
Describe the solution you'd like
Add a logic to convert "\n" to "\n" in the cert string if it is there , maybe in ServiceStubOptionsTemplate class.
Describe alternatives you've considered
I replaced ServiceStubsAutoConfiguration with our customized/extended class which converts "\n" to "\n" in mtlsProperties' cert and key.
@SpringBootApplication(exclude = [ServiceStubsAutoConfiguration::class])
- Dominant language
- Java
- Stars
- 434
- Forks
- 252
- Avg merge
- 2d 22h
- Merged PRs (30d)
- 19
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from temporalio/sdk-java
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
temporalio/sdk-java#2676 · 8 comments · 2 reactions ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 55/100
temporalio/sdk-java#3108 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 68/100
temporalio/sdk-java#3106 ·
Maintainers usually reply within 1 day
-
Warn if the SDK tried to send a payload above a specific size - JavaPossibly taken @jmaeagle99 claimed this 24 days ago. Open
temporalio/sdk-java#3059 · 1 assignee ·
Maintainers usually reply within 1 day
-
Promise.get(timeout, unit) throws a misleading TimeoutException when the workflow is canceledMay be free again @Quinn-With-Two-Ns claimed this 38 days ago, and no pull request is open. Open
temporalio/sdk-java#3026 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
All issues in temporalio/sdk-java
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
grimmory-tools/grimmory#2850 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
aoqia194/leaf-loader#19 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
apache/streampark#4521 ·
-
Update license yearOpen0 - Backlog 1 - Ready documentation good first issue help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 78/100