CI results tables need better pass/fail symbols
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 65/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- javascript
- Domain
- testing
Research direction
Start by reading the discussion in issue #5129 and the linked example comment on pull request #5184, then find where CI results tables are generated. Compare the proposed symbol pairs and ASCII labels for readability in tables and email. Done when the selected pass and fail labels are clearly distinguishable in both contexts.
Written by the indexing model from the issue text.
Description
The choice in #5129 of (π, π) turned out too be too visually similar for me, as seen at https://github.com/tc39/test262/pull/5184#issuecomment-6980793722 and especially in email.
| Test | Engine262 | GraalJS | JavaScriptCore | QuickJS | SpiderMonkey | V8 | XS |
|---|---|---|---|---|---|---|---|
| built-ins/String/prototype/substr/B.2.3.js | π | π | π | π | π | π | π |
| built-ins/String/prototype/substr/length-falsey.js | π | π | π | π | π | π | π |
| built-ins/String/prototype/substr/length-negative.js | π | π | π | π | π | π | π |
| built-ins/String/prototype/substr/length-positive.js | π | π | π | π | π | π | π |
| built-ins/String/prototype/substr/length-to-int-err.js | π | π | π | π | π | π | π |
| built-ins/String/prototype/substr/length-undef.js | π | π | π | π | π | π | π |
| built-ins/String/prototype/substr/length.js | π | π | π | π | π | π | π |
| built-ins/String/prototype/substr/name.js | π | π | π | π | π | π | π |
| built-ins/String/prototype/substr/not-a-constructor.js | π | π | π | π | π | π | π |
| built-ins/String/prototype/substr/start-and-length-as-numbers.js | π | π | π | π | π | π | π |
| built-ins/String/prototype/substr/start-negative.js | π | π | π | π | π | π | π |
| built-ins/String/prototype/substr/start-to-int-err.js | π | π | π | π | π | π | π |
| built-ins/String/prototype/substr/surrogate-pairs.js | π | π | π | π | π | π | π |
| built-ins/String/prototype/substr/this-non-obj-coerce.js | π | π | π | π | π | π | π |
| built-ins/String/prototype/substr/this-to-str-err.js | π | π | π | π | π | π | π |
Here are some alternative pairs:
WHITE HEAVY CHECK MARK and NEGATIVE SQUARED CROSS MARK
(U+2705, U+274E)
| Test | Engine262 | GraalJS | JavaScriptCore | QuickJS | SpiderMonkey | V8 | XS |
|---|---|---|---|---|---|---|---|
| built-ins/String/prototype/substr/start-and-length-as-numbers.js | β | β | β | β | β | β | β |
BALLOT BOX WITH CHECK and NEGATIVE SQUARED CROSS MARK
(U+2611, U+274E)
| Test | Engine262 | GraalJS | JavaScriptCore | QuickJS | SpiderMonkey | V8 | XS |
|---|---|---|---|---|---|---|---|
| built-ins/String/prototype/substr/start-and-length-as-numbers.js | β | βοΈ | βοΈ | βοΈ | βοΈ | βοΈ | β |
BALLOT BOX WITH BOLD CHECK and BALLOT BOX WITH BOLD SCRIPT X
(U+1F5F9, U+1F5F7)
| Test | Engine262 | GraalJS | JavaScriptCore | QuickJS | SpiderMonkey | V8 | XS |
|---|---|---|---|---|---|---|---|
| built-ins/String/prototype/substr/start-and-length-as-numbers.js | π· | πΉ | πΉ | πΉ | πΉ | πΉ | π· |
CHECK MARK and BALLOT X
(U+2713, U+2717)
| Test | Engine262 | GraalJS | JavaScriptCore | QuickJS | SpiderMonkey | V8 | XS |
|---|---|---|---|---|---|---|---|
| built-ins/String/prototype/substr/start-and-length-as-numbers.js | β | β | β | β | β | β | β |
FACE WITH PARTY HORN AND PARTY HAT and LOUDLY CRYING FACE
(U+1F973, U+1F62D)
| Test | Engine262 | GraalJS | JavaScriptCore | QuickJS | SpiderMonkey | V8 | XS |
|---|---|---|---|---|---|---|---|
| built-ins/String/prototype/substr/start-and-length-as-numbers.js | π | π₯³ | π₯³ | π₯³ | π₯³ | π₯³ | π |
PASS and FAIL
(literal ASCII text)
| Test | Engine262 | GraalJS | JavaScriptCore | QuickJS | SpiderMonkey | V8 | XS |
|---|---|---|---|---|---|---|---|
| built-ins/String/prototype/substr/start-and-length-as-numbers.js | FAIL | PASS | PASS | PASS | PASS | PASS | FAIL |
- Dominant language
- JavaScript
- Stars
- 2.9k
- Forks
- 571
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 13
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up β it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from tc39/test262
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
tc39/test262#5190 Β· 1 reaction Β·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
tc39/test262#5159 Β· 2 comments Β·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
tc39/test262#5133 Β· 1 comment Β·
Maintainers usually reply within 1 day
-
Uint8Array.prototype.toHex tests do not test for paddingPossibly taken @bakkot claimed this 24 days ago. Open
Difficulty 1/5 Under an hour Newbie friendliness 90/100
tc39/test262#5130 Β· 1 comment Β·
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
all-contributors/cli#690 Β·
Maintainers usually reply within 1 day
-
area: ui Bug Payload OSS
Difficulty 1/5 Under an hour Newbie friendliness 88/100
payloadcms/payload#19839 Β·
Maintainers usually reply within 1 day
-
Add: C+ ClassicsOpenapproved channels:add check:passed
Difficulty 1/5 Under an hour Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
AllTheMods/ATM10-Aeronautics#167 Β·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day