CI results tables need better pass/fail symbols

Open Beginner friendly
#5,185 7 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
65/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
javascript
Domain
testing

Research direction

Start by reading the discussion in issue #5129 and the linked example comment on pull request #5184, then find where CI results tables are generated. Compare the proposed symbol pairs and ASCII labels for readability in tables and email. Done when the selected pass and fail labels are clearly distinguishable in both contexts.

Written by the indexing model from the issue text.

Description

The choice in #5129 of (πŸ‘, πŸ‘Ž) turned out too be too visually similar for me, as seen at https://github.com/tc39/test262/pull/5184#issuecomment-6980793722 and especially in email.

Test Engine262 GraalJS JavaScriptCore QuickJS SpiderMonkey V8 XS
built-ins/String/prototype/substr/B.2.3.js πŸ‘Ž πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘
built-ins/String/prototype/substr/length-falsey.js πŸ‘Ž πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘
built-ins/String/prototype/substr/length-negative.js πŸ‘Ž πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘
built-ins/String/prototype/substr/length-positive.js πŸ‘Ž πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘
built-ins/String/prototype/substr/length-to-int-err.js πŸ‘Ž πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘
built-ins/String/prototype/substr/length-undef.js πŸ‘Ž πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘
built-ins/String/prototype/substr/length.js πŸ‘Ž πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘
built-ins/String/prototype/substr/name.js πŸ‘Ž πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘
built-ins/String/prototype/substr/not-a-constructor.js πŸ‘Ž πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘
built-ins/String/prototype/substr/start-and-length-as-numbers.js πŸ‘Ž πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘Ž
built-ins/String/prototype/substr/start-negative.js πŸ‘Ž πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘
built-ins/String/prototype/substr/start-to-int-err.js πŸ‘Ž πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘
built-ins/String/prototype/substr/surrogate-pairs.js πŸ‘Ž πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘
built-ins/String/prototype/substr/this-non-obj-coerce.js πŸ‘Ž πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘
built-ins/String/prototype/substr/this-to-str-err.js πŸ‘Ž πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘

Here are some alternative pairs:

WHITE HEAVY CHECK MARK and NEGATIVE SQUARED CROSS MARK

(U+2705, U+274E)

Test Engine262 GraalJS JavaScriptCore QuickJS SpiderMonkey V8 XS
built-ins/String/prototype/substr/start-and-length-as-numbers.js ❎ βœ… βœ… βœ… βœ… βœ… ❎
BALLOT BOX WITH CHECK and NEGATIVE SQUARED CROSS MARK

(U+2611, U+274E)

Test Engine262 GraalJS JavaScriptCore QuickJS SpiderMonkey V8 XS
built-ins/String/prototype/substr/start-and-length-as-numbers.js ❎ β˜‘οΈ β˜‘οΈ β˜‘οΈ β˜‘οΈ β˜‘οΈ ❎
BALLOT BOX WITH BOLD CHECK and BALLOT BOX WITH BOLD SCRIPT X

(U+1F5F9, U+1F5F7)

Test Engine262 GraalJS JavaScriptCore QuickJS SpiderMonkey V8 XS
built-ins/String/prototype/substr/start-and-length-as-numbers.js πŸ—· πŸ—Ή πŸ—Ή πŸ—Ή πŸ—Ή πŸ—Ή πŸ—·
CHECK MARK and BALLOT X

(U+2713, U+2717)

Test Engine262 GraalJS JavaScriptCore QuickJS SpiderMonkey V8 XS
built-ins/String/prototype/substr/start-and-length-as-numbers.js βœ— βœ“ βœ“ βœ“ βœ“ βœ“ βœ—
FACE WITH PARTY HORN AND PARTY HAT and LOUDLY CRYING FACE

(U+1F973, U+1F62D)

Test Engine262 GraalJS JavaScriptCore QuickJS SpiderMonkey V8 XS
built-ins/String/prototype/substr/start-and-length-as-numbers.js 😭 πŸ₯³ πŸ₯³ πŸ₯³ πŸ₯³ πŸ₯³ 😭
PASS and FAIL

(literal ASCII text)

Test Engine262 GraalJS JavaScriptCore QuickJS SpiderMonkey V8 XS
built-ins/String/prototype/substr/start-and-length-as-numbers.js FAIL PASS PASS PASS PASS PASS FAIL
Dominant language
JavaScript
Stars
2.9k
Forks
571
Avg merge
1d 22h
Merged PRs (30d)
13

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up β€” it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from tc39/test262

All issues in tc39/test262

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.